Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.nose3: drop #330741

Merged
merged 9 commits into from
Aug 2, 2024
Merged

python3Packages.nose3: drop #330741

merged 9 commits into from
Aug 2, 2024

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Jul 28, 2024

Description of changes

If nose is so good why isn’t there a nose3?

#326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

license = licenses.mpl20;
maintainers = [ maintainers.willibutz ];
platforms = platforms.unix;
sourceProvenance = [ lib.sourceTypes.fromSource ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source should be not set as otherwise we had a lot of code deduplication

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #329470 (comment) for my (and others’) thoughts on that. (If sourceProvenance = [ lib.sourceTypes.fromSource ]; is redundant, so is sourceProvenance = [ lib.sourceTypes.fromSource lib.sourceTypes.binaryNativeCode ]; and arguably even sourceProvenance = [ lib.sourceTypes.binaryNativeCode ];, not to mention license = lib.licenses.free; which nobody would argue for dropping.)

@natsukium
Copy link
Member

Result of nixpkgs-review pr 330741 at 036cfae1 run on x86_64-linux 1

5 packages built successfully:
  • gixy
  • grin
  • nixpkgs-manual
  • svtplay-dl
  • tests.testers.lycheeLinkCheck.network

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase?

@emilazy
Copy link
Member Author

emilazy commented Jul 31, 2024

Rebased. (I guess I’ll have to rebase #330725 afterwards too…)

@natsukium
Copy link
Member

Oh, sorry, I merged the #330725 first. I'll rebase.

@emilazy
Copy link
Member Author

emilazy commented Aug 2, 2024

I think we should be good to merge this.

@emilazy emilazy merged commit 8764d89 into NixOS:master Aug 2, 2024
26 of 27 checks passed
@emilazy emilazy deleted the push-rlvumrtyxrmk branch August 26, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants