-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.nose3: drop #330741
python3Packages.nose3: drop #330741
Conversation
license = licenses.mpl20; | ||
maintainers = [ maintainers.willibutz ]; | ||
platforms = platforms.unix; | ||
sourceProvenance = [ lib.sourceTypes.fromSource ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source should be not set as otherwise we had a lot of code deduplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #329470 (comment) for my (and others’) thoughts on that. (If sourceProvenance = [ lib.sourceTypes.fromSource ];
is redundant, so is sourceProvenance = [ lib.sourceTypes.fromSource lib.sourceTypes.binaryNativeCode ];
and arguably even sourceProvenance = [ lib.sourceTypes.binaryNativeCode ];
, not to mention license = lib.licenses.free;
which nobody would argue for dropping.)
6e30c10
to
036cfae
Compare
Result of 5 packages built successfully:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase?
036cfae
to
15f6dd3
Compare
Rebased. (I guess I’ll have to rebase #330725 afterwards too…) |
Oh, sorry, I merged the #330725 first. I'll rebase. |
These exercise Gixy through the NixOS nginx module.
15f6dd3
to
9b7e7d7
Compare
I think we should be good to merge this. |
Description of changes
If nose is so good why isn’t there a nose3?
#326513
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.