Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-information: 0.6.0 -> 0.7.0 #332785

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Aug 6, 2024

Description of changes

Required to build with Rust 1.80.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@eopb eopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙌

@eopb
Copy link
Member

eopb commented Aug 7, 2024

Result of nixpkgs-review pr 332785 run on x86_64-linux 1

1 package built:
  • cargo-information

@alyssais
Copy link
Member Author

alyssais commented Aug 9, 2024

macOS build is failing because it's trying to build curl, even if I put curl in buildInputs. Not sure why…

Required to build with Rust 1.80.

Link: rust-lang/rust#127343
@emilazy emilazy force-pushed the cargo-information-0.7.0 branch from 43b8ec0 to 7773aa0 Compare August 9, 2024 20:48
@emilazy
Copy link
Member

emilazy commented Aug 9, 2024

Adding curl worked for me on x86_64-darwin, aarch64-darwin, and x86_64-linux. Merging.

@emilazy emilazy merged commit 5a4c4d2 into NixOS:master Aug 9, 2024
9 of 10 checks passed
@alyssais alyssais deleted the cargo-information-0.7.0 branch September 2, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants