regression: type annotations needed for Box<_> #127343

Mark-Simulacrum · 2024-07-04T21:36:17Z

Mostly reverse-dependencies of the time crate (before time-rs/time@5b0c627, released in 0.3.35). My sense is there's probably nothing to do here, but lots of crates have older version of time in Cargo.lock. Nominating for libs-api to approve the wide spectrum of regressions. (Caused by #99969).

[INFO] [stdout] error[E0282]: type annotations needed for `Box<_>`
[INFO] [stdout]   --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.20/src/format_description/parse/mod.rs:83:9
[INFO] [stdout]    |
[INFO] [stdout] 83 |     let items = format_items
[INFO] [stdout]    |         ^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 86 |     Ok(items.into())
[INFO] [stdout]    |              ---- type must be known at this point
[INFO] [stdout]    |
[INFO] [stdout] help: consider giving `items` an explicit type, where the placeholders `_` are specified
[INFO] [stdout]    |
[INFO] [stdout] 83 |     let items: Box<_> = format_items
[INFO] [stdout]    |              ++++++++
[INFO] [stdout] 
[INFO] [stdout]

The text was updated successfully, but these errors were encountered:

dtolnay · 2024-07-09T17:14:41Z

We discussed this regression in today's @rust-lang/libs-api team meeting, and agree there's nothing to change on Rust's end. Those repos that have an old version of time in a lockfile will need to update that.

I would love if someone were interested in cataloguing all the "type annotations needed" type inference breakages resulting from the addition of a trait impl through the history of the standard library, and think about building static analysis that could forewarn about code that is at risk of becoming ambiguous (e.g. a += b.as_ref()). It may be something that widely used crates want to enforce in CI.

Time 0.3.27 fails to build with Rust 1.80.0, released today[0]. This updates time to 0.3.36, which successfully builds with Rust 1.80.0. [0] rust-lang/rust#127343 Fixes ClementTsang#1500 Signed-off-by: Randy Barlow <randy@electronsweatshop.com>

The version of time that bottom 0.9.6 uses does not build with Rust 1.80.0[0][1]. This bumps time to 0.3.36 to address the issue. [0] ClementTsang/bottom#1500 [1] rust-lang/rust#127343 Signed-off-by: Randy Barlow <randy@electronsweatshop.com>

cyqsimon · 2024-07-26T08:00:29Z

Backward compatibility is difficult =(

ayushgupta0610 · 2024-07-26T14:34:09Z

So what exactly is the solution to resolve this?

BurntSushi · 2024-07-26T14:37:10Z

@ayushgupta0610 Answer is here: #127343 (comment)

Rust `1.80.0` introduced a [new trait implementation](rust-lang/rust#99969) which caused builds of [old versions of the `time` crate to fail](rust-lang/rust#127343). Since `cargo clone` depends on one of these old `time` versions, builds with rust `1.80.0` or later fail: ``` error[E0282]: type annotations needed for `Box<_>` --> /home/ethan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.30/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | help: consider giving `items` an explicit type, where the placeholders `_` are specified | 83 | let items: Box<_> = format_items | ++++++++ For more information about this error, try `rustc --explain E0282`. error: could not compile `time` (lib) due to 1 previous error ``` Updating to a version of time with this regression fixed, with `cargo update -p time`, fixes the build of `cargo clone`. It would also be helpful to get a new release of `cargo clone` after this is merged, since this is also causing the `cargo clone` package to [fail on NixOS](NixOS/nixpkgs#332957 (comment)).

rust-lang/rust#127343

…roken (!31) Due to new rustc builder v1.80, some package builds are broken (see rust-lang/rust#127343). This PR add difftastic configuration with a boolean switch between delta/difftastic and deactivate delta due to previously mentioned issues. Approved-by: Romain Deville <code@romaindeville.fr> Merged-by: Romain Deville <code@romaindeville.fr> See merge request https://framagit.org/rdeville-public/dotfiles/nixos-config/-/merge_requests/31

…e` dependency to build on 1.80.0 Our old nightly (1.65) pins `time-macros` to an old version, which requires `time` to stay on an old version. But since 1.80 broke `time` (due to time-rs/time#693 and rust-lang/rust#127343), we need to update `time`. Doing this requires `time-macros` to be upgraded, which requires at least rust 1.67. There's an old PR, #811, for this, but it needs rebasing. So for now, removing `git-testament` and its `time` dependency is simpler, and we can add it back later once we update to a newer nightly.

…e` dependency to build on 1.80.0 (#1115) * Fixes #1109. Our old nightly (1.65) pins `time-macros` to an old version, which requires `time` to stay on an old version. But since 1.80 broke `time` (due to time-rs/time#693 and rust-lang/rust#127343), we need to update `time`. Doing this requires `time-macros` to be upgraded, which requires at least rust 1.67. There's an old PR, #811, for this, but it needs rebasing. So for now, removing `git-testament` and its `time` dependency is simpler, and we can add it back later once we update to a newer nightly. With this fix, both `cargo build -p c2rust` (the pinned nightly) and `cargo +stable build -p c2rust` (1.80.1) now work. If this is good, and once we merge this, we'll release a new version with the fix.

``` error[E0282]: type annotations needed for `Box<_>` --> ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | = note: this is an inference error on crate `time` caused by a change in Rust 1.80.0; update `time` to version `>=0.3.35` ``` Partially address rust-lang#127343.

Emit specific message for time<=0.3.35 ``` error[E0282]: type annotations needed for `Box<_>` --> /home/gh-estebank/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | = note: this is an inference error on `time` caused by a change in Rust 1.80.0; update `time` to version `>=0.3.36` ``` Partially mitigate the fallout from rust-lang#127343. Although the biggest benefit of this would have been if we had had this in 1.80 before it became stable, the long-tail of that change will be felt for a *long* time, so better late than never. We can also emit an even more targeted error instead of this inference failure.

Rollup merge of rust-lang#129343 - estebank:time-version, r=jieyouxu Emit specific message for time<=0.3.35 ``` error[E0282]: type annotations needed for `Box<_>` --> /home/gh-estebank/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | = note: this is an inference error on `time` caused by a change in Rust 1.80.0; update `time` to version `>=0.3.36` ``` Partially mitigate the fallout from rust-lang#127343. Although the biggest benefit of this would have been if we had had this in 1.80 before it became stable, the long-tail of that change will be felt for a *long* time, so better late than never. We can also emit an even more targeted error instead of this inference failure.

``` error[E0282]: type annotations needed for `Box<_>` --> ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | = note: this is an inference error on crate `time` caused by a change in Rust 1.80.0; update `time` to version `>=0.3.35` ``` Partially address rust-lang#127343. (cherry picked from commit b013a3d)

resctl-demo v2.2.5 (crates.io) uses time v0.3.34, which fails to build on rust >= 1.8.0 (rust-lang/rust#127343). Fix the toolchain version to 1.79.0 until a new resctl-demo version is released. Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>

``` error[E0282]: type annotations needed for `Box<_>` --> ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | = note: this is an inference error on crate `time` caused by a change in Rust 1.80.0; update `time` to version `>=0.3.35` ``` Partially address rust-lang#127343. (cherry picked from commit b013a3d)

…e` dependency to build on 1.80.0 (immunant#1115) * Fixes immunant#1109. Our old nightly (1.65) pins `time-macros` to an old version, which requires `time` to stay on an old version. But since 1.80 broke `time` (due to time-rs/time#693 and rust-lang/rust#127343), we need to update `time`. Doing this requires `time-macros` to be upgraded, which requires at least rust 1.67. There's an old PR, immunant#811, for this, but it needs rebasing. So for now, removing `git-testament` and its `time` dependency is simpler, and we can add it back later once we update to a newer nightly. With this fix, both `cargo build -p c2rust` (the pinned nightly) and `cargo +stable build -p c2rust` (1.80.1) now work. If this is good, and once we merge this, we'll release a new version with the fix.

Required to build with Rust 1.80. Link: rust-lang/rust#127343

Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels Jul 4, 2024

Mark-Simulacrum added this to the 1.80.0 milestone Jul 4, 2024

rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jul 4, 2024

Mark-Simulacrum mentioned this issue Jul 4, 2024

Crater runs for 1.80 #126791

Closed

saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 4, 2024

dtolnay closed this as completed Jul 9, 2024

apiraino removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels Jul 10, 2024

Urgau mentioned this issue Jul 25, 2024

Regression in type inferencing in 1.80.0 #128181

Closed

bowlofeggs mentioned this issue Jul 25, 2024

virtual/rust: Add 1.80.1 gentoo/gentoo#37727

Closed

8 tasks

This was referenced Jul 26, 2024

Update time from 0.3.27 to 0.3.36 ClementTsang/bottom#1501

Closed

Build failure with Rust 1.80.0 ClementTsang/bottom#1500

Closed

Celeo mentioned this issue Jul 26, 2024

chore: bump Cargo.lock kbknapp/cargo-outdated#393

Open

This was referenced Jul 26, 2024

build(deps): bump time dependency eza-community/eza#1070

Merged

Bump time to 0.3.36 (fixes #3043) sharkdp/bat#3045

Merged

lqd mentioned this issue Jul 26, 2024

Regression in type annotations needed for check between 1.79 and 1.80 #128242

Closed

barshaul mentioned this issue Jul 27, 2024

Merge from redis-rs and fixes for rust 1.80.0 valkey-io/valkey-glide#2029

Merged

rickyrombo mentioned this issue Jul 29, 2024

Pin Rust version to 1.79.0 AudiusProject/audius-protocol#9290

Merged

sunshowers mentioned this issue Jul 30, 2024

update time dependency oxidecomputer/helios#167

Merged

mrkcee mentioned this issue Jul 30, 2024

speakersafetyd and rust 1.80 AsahiLinux/speakersafetyd#15

Closed

eopb mentioned this issue Aug 24, 2024

Update time to fix build failures on rust 1.80.0 JanLikar/cargo-clone#134

Merged

KatyaRyazantseva mentioned this issue Aug 24, 2024

Lints to ensure link text for EIPs should match the EIP's number ethereum/eipw#99

Open

kornelski added a commit to kornelski/cargo that referenced this issue Aug 25, 2024

Workaround for type inference breakage in the time crate

82f8d32

rust-lang/rust#127343

kornelski mentioned this issue Aug 25, 2024

Workaround for type inference breakage in the time crate rust-lang/cargo#14452

Closed

kornelski added a commit to kornelski/cargo that referenced this issue Aug 25, 2024

Workaround for type inference breakage in the time crate

c803297

rust-lang/rust#127343

ghpzin mentioned this issue Aug 26, 2024

fix build with rust 1.80 sloganking/codemov#16

Open

kornelski mentioned this issue Aug 27, 2024

rust 1.80.0 build issue immunant/c2rust#1109

Closed

kkysen mentioned this issue Aug 28, 2024

transpile: remove git-testament dependency (for now) to remove time dependency to build on 1.80.0 immunant/c2rust#1115

Merged

FriederHannenheim mentioned this issue Aug 29, 2024

Update dependencies so yofi builds with the latest Rust l4l/yofi#174

Merged

kornelski mentioned this issue Aug 29, 2024

Ensure incompatible versions of time are not allowed actix/actix-web#3463

Open

r-c-n mentioned this issue Aug 30, 2024

Job "Build resctl-demo" failing (time crate fails to build) iocost-benchmark/iocost-benchmarks-ci#33

Closed

r-c-n mentioned this issue Aug 30, 2024

build-resctl-demo: workaround fix for resctl-demo v2.2.5 (#33) iocost-benchmark/iocost-benchmarks-ci#34

Merged

dtolnay removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Sep 3, 2024

LuySeiwert mentioned this issue Sep 7, 2024

Cannot build Foxhound release v121.0 SAP/project-foxhound#222

Closed

reckenrode pushed a commit to reckenrode/nixpkgs that referenced this issue Sep 15, 2024

symbolicator: 23.11.2 -> 24.7.1

7e88d3f

Required to build with Rust 1.80. Link: rust-lang/rust#127343

AnActualEmerald mentioned this issue Sep 18, 2024

Replace lazy_static with LazyLock AnActualEmerald/thermite#12

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

regression: type annotations needed for Box<_> #127343

regression: type annotations needed for Box<_> #127343

Mark-Simulacrum commented Jul 4, 2024

dtolnay commented Jul 9, 2024

cyqsimon commented Jul 26, 2024

ayushgupta0610 commented Jul 26, 2024

BurntSushi commented Jul 26, 2024

regression: type annotations needed for Box<_> #127343

regression: type annotations needed for Box<_> #127343

Comments

Mark-Simulacrum commented Jul 4, 2024

dtolnay commented Jul 9, 2024

cyqsimon commented Jul 26, 2024

ayushgupta0610 commented Jul 26, 2024

BurntSushi commented Jul 26, 2024