alloc: implement FromIterator for Box<str> #99969

calebsander · 2022-07-30T23:31:24Z

Box<[T]> implements FromIterator<T> using Vec<T> + into_boxed_slice().
Add analogous FromIterator implementations for Box<str>
matching the current implementations for String.
Remove the Global allocator requirement for FromIterator<Box<str>> too.

ACP: rust-lang/libs-team#196

rust-highfive · 2022-07-30T23:31:27Z

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

rustbot · 2022-07-30T23:31:27Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

calebsander · 2022-07-30T23:32:04Z

@rustbot label +T-libs-api -T-libs

pitaj · 2023-01-29T03:22:45Z

I believe this does require an ACP (insta-stable new implementation of stable trait on stable type). Please create one if you haven't already. Link it here and then label this PR as S-waiting-on-ACP.

@rustbot label -S-waiting-on-review +S-waiting-on-author

calebsander · 2023-03-25T17:13:51Z

ACP: rust-lang/libs-team#196

calebsander · 2023-03-25T17:14:45Z

@rustbot label +S-waiting-on-review -S-waiting-on-author

dtolnay · 2024-01-26T03:35:07Z

@rust-lang/libs-api:
@rfcbot fcp merge

+ impl FromIterator<char> for Box<str>
+ impl FromIterator<&char> for Box<str>
+ impl FromIterator<&str> for Box<str>
+ impl FromIterator<String> for Box<str>
+ impl<A: Allocator> FromIterator<Box<str, A>> for Box<str>
+ impl FromIterator<Cow<'_, str>> for Box<str>

- impl FromIterator<Box<str>> for String
+ impl<A: Allocator> FromIterator<Box<str, A>> for String

- impl Extend<Box<str>> for String
+ impl<A: Allocator> Extend<Box<str, A>> for String

rfcbot · 2024-01-26T03:35:09Z

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2024-03-05T17:38:31Z

🔔 This is now entering its final comment period, as per the review above. 🔔

Previously shadow wouldn't compile on nightly due to a rust type inference change that breaks existing rust code, and they intend to stabilize this change. For us that breakage occurs in the time crate, so this PR upgrades all dependencies (including the time library) to fix the build errors. rust-lang/rust#99969 (comment) rust-lang/rust#125319

Previously shadow wouldn't compile on nightly due to a rust compiler type inference change that breaks existing rust code, and they intend to stabilize this change in a couple of months. For us that breakage occurs in the time crate, so this PR upgrades all dependencies (including the time library) to fix the build error. rust-lang/rust#99969 (comment) rust-lang/rust#125319

apiraino · 2024-06-19T15:09:53Z

Adding relnotes label because someone reported this in #126685 (up to t-release to decide)

@rustbot label +relnotes

`rustc --version`: `v1.80.0` has a type inference regression. This causes compilation of `centerpiece` to fail, because we use an affected version of the `time` crate. This updates the time crate to a released version with a fix. Reference: - NixOS/nixpkgs#332957 - rust-lang/rust#125319 - rust-lang/rust#99969

tgross35 · 2024-08-17T12:31:16Z

It seems this did not make it into the "Compatibility Notes" for https://doc.rust-lang.org/nightly/releases.html#version-1800-2024-07-25. @apiraino could it be retroactively added?

(coming here from the IRLO discussion https://internals.rust-lang.org/t/type-inference-breakage-in-1-80-has-not-been-handled-well)

apiraino · 2024-08-17T13:42:12Z

Thanks Trevor for the ping. Relayed to T-release on Zulip.

…r=cuviper Add a missing compatibility note in the 1.80.0 release notes rust-lang#99969 missed being included in the release notes. As discussed [on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/.2399969.20missed.20the.20release.20notes/near/463002451). (the discussion about the _a posteriori_ breakage the ecosystem is experiencing is another topic) Thanks r? `@rust-lang/release`

…r=cuviper Add a missing compatibility note in the 1.80.0 release notes rust-lang#99969 missed being included in the release notes. As discussed [on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/.2399969.20missed.20the.20release.20notes/near/463002451). (the discussion about the _a posteriori_ breakage the ecosystem is experiencing is another topic) Thanks r? ``@rust-lang/release``

…r=cuviper Add a missing compatibility note in the 1.80.0 release notes rust-lang#99969 missed being included in the release notes. As discussed [on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/.2399969.20missed.20the.20release.20notes/near/463002451). (the discussion about the _a posteriori_ breakage the ecosystem is experiencing is another topic) Thanks r? ```@rust-lang/release```

…r=cuviper Add a missing compatibility note in the 1.80.0 release notes rust-lang#99969 missed being included in the release notes. As discussed [on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/.2399969.20missed.20the.20release.20notes/near/463002451). (the discussion about the _a posteriori_ breakage the ecosystem is experiencing is another topic) Thanks r? ````@rust-lang/release````

…r=cuviper Add a missing compatibility note in the 1.80.0 release notes rust-lang#99969 missed being included in the release notes. As discussed [on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/.2399969.20missed.20the.20release.20notes/near/463002451). (the discussion about the _a posteriori_ breakage the ecosystem is experiencing is another topic) Thanks r? `````@rust-lang/release`````

…r=cuviper Add a missing compatibility note in the 1.80.0 release notes rust-lang#99969 missed being included in the release notes. As discussed [on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/.2399969.20missed.20the.20release.20notes/near/463002451). (the discussion about the _a posteriori_ breakage the ecosystem is experiencing is another topic) Thanks r? ``````@rust-lang/release``````

Rollup merge of rust-lang#129263 - apiraino:add-missing-compat-note, r=cuviper Add a missing compatibility note in the 1.80.0 release notes rust-lang#99969 missed being included in the release notes. As discussed [on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/.2399969.20missed.20the.20release.20notes/near/463002451). (the discussion about the _a posteriori_ breakage the ecosystem is experiencing is another topic) Thanks r? ``````@rust-lang/release``````

Rust `1.80.0` introduced a [new trait implementation](rust-lang/rust#99969) which caused builds of [old versions of the `time` crate to fail](rust-lang/rust#127343). Since `cargo clone` depends on one of these old `time` versions, build with rust `1.80.0` or later fail: ``` error[E0282]: type annotations needed for `Box<_>` --> /home/ethan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.30/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | help: consider giving `items` an explicit type, where the placeholders `_` are specified | 83 | let items: Box<_> = format_items | ++++++++ For more information about this error, try `rustc --explain E0282`. error: could not compile `time` (lib) due to 1 previous error ``` Updating to a version of time with this regression fixed, with `cargo update -p time`, fixes the build of `cargo clone`. It would also be helpful to get a new release of `cargo clone` after this is merged, since this is also causing the `cargo clone` package to [fail on NixOS](NixOS/nixpkgs#332957 (comment)).

Rust `1.80.0` introduced a [new trait implementation](rust-lang/rust#99969) which caused builds of [old versions of the `time` crate to fail](rust-lang/rust#127343). Since `cargo clone` depends on one of these old `time` versions, builds with rust `1.80.0` or later fail: ``` error[E0282]: type annotations needed for `Box<_>` --> /home/ethan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.30/src/format_description/parse/mod.rs:83:9 | 83 | let items = format_items | ^^^^^ ... 86 | Ok(items.into()) | ---- type must be known at this point | help: consider giving `items` an explicit type, where the placeholders `_` are specified | 83 | let items: Box<_> = format_items | ++++++++ For more information about this error, try `rustc --explain E0282`. error: could not compile `time` (lib) due to 1 previous error ``` Updating to a version of time with this regression fixed, with `cargo update -p time`, fixes the build of `cargo clone`. It would also be helpful to get a new release of `cargo clone` after this is merged, since this is also causing the `cargo clone` package to [fail on NixOS](NixOS/nixpkgs#332957 (comment)).

rust-highfive assigned kennytm Jul 30, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 30, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2022

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 30, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2022

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2023

calebsander mentioned this pull request Mar 25, 2023

ACP: Implement FromIterator for Box<str> rust-lang/libs-team#196

Closed

calebsander force-pushed the feature/collect-box-str branch from d456168 to 55ba9e7 Compare March 25, 2023 17:14

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 25, 2023

Dylan-DPC added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2023

dtolnay assigned dtolnay and unassigned kennytm Jan 26, 2024

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jan 26, 2024

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Mar 5, 2024

stevenengler mentioned this pull request May 22, 2024

Upgrade dependencies to fix rust nightly regression shadow/shadow#3334

Merged

mitsuhiko mentioned this pull request May 23, 2024

Route incref via vtable to avoid alignment issues mitsuhiko/minijinja#516

Merged

ehuss mentioned this pull request May 29, 2024

Update time dependency. rust-lang/triagebot#1816

Merged

apiraino mentioned this pull request Jun 19, 2024

Regression in type inference between stable 1.79.0 and nightly-2024-06-19 #126685

Open

rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 19, 2024

Mark-Simulacrum mentioned this pull request Jul 4, 2024

regression: type annotations needed for Box<_> #127343

Open

a-kenji mentioned this pull request Aug 10, 2024

🚑️ Fix compilation with rustc v1.80 friedow/centerpiece#180

Merged

glowcoil mentioned this pull request Aug 10, 2024

Update time dependency to 0.3.36 free-audio/clap-validator#19

Merged

apiraino mentioned this pull request Aug 19, 2024

Add a missing compatibility note in the 1.80.0 release notes #129263

Merged

estebank mentioned this pull request Aug 21, 2024

Revert "alloc: implement FromIterator for Box<str>" #129379

Closed

eopb mentioned this pull request Aug 24, 2024

Update time to fix build failures on rust 1.80.0 JanLikar/cargo-clone#134

Merged

brsvh mentioned this pull request Aug 30, 2024

Build failed at 1.2.0 with Rust 1.80.0 konradsz/igrep#69

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

alloc: implement FromIterator for Box<str> #99969

alloc: implement FromIterator for Box<str> #99969

calebsander commented Jul 30, 2022 •

edited by Dylan-DPC

Loading

rust-highfive commented Jul 30, 2022

rustbot commented Jul 30, 2022

calebsander commented Jul 30, 2022

pitaj commented Jan 29, 2023

calebsander commented Mar 25, 2023

calebsander commented Mar 25, 2023

dtolnay commented Jan 26, 2024

rfcbot commented Jan 26, 2024 •

edited by joshtriplett

Loading

rfcbot commented Mar 5, 2024

apiraino commented Jun 19, 2024 •

edited

Loading

tgross35 commented Aug 17, 2024

apiraino commented Aug 17, 2024

alloc: implement FromIterator for Box<str> #99969

alloc: implement FromIterator for Box<str> #99969

Conversation

calebsander commented Jul 30, 2022 • edited by Dylan-DPC Loading

rust-highfive commented Jul 30, 2022

rustbot commented Jul 30, 2022

calebsander commented Jul 30, 2022

pitaj commented Jan 29, 2023

calebsander commented Mar 25, 2023

calebsander commented Mar 25, 2023

dtolnay commented Jan 26, 2024

rfcbot commented Jan 26, 2024 • edited by joshtriplett Loading

rfcbot commented Mar 5, 2024

apiraino commented Jun 19, 2024 • edited Loading

tgross35 commented Aug 17, 2024

apiraino commented Aug 17, 2024

calebsander commented Jul 30, 2022 •

edited by Dylan-DPC

Loading

rfcbot commented Jan 26, 2024 •

edited by joshtriplett

Loading

apiraino commented Jun 19, 2024 •

edited

Loading