Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑️ Fix compilation with rustc v1.80 #180

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

a-kenji
Copy link
Collaborator

@a-kenji a-kenji commented Aug 10, 2024

rustc --version: v1.80.0 has a type inference regression. This causes compilation of centerpiece to fail, because we use an affected version of the time crate.

This updates the time crate to a released version with a fix.

Reference:

`rustc --version`: `v1.80.0` has a type inference regression.
This causes compilation of `centerpiece` to fail, because we use an
affected version of the `time` crate.

This updates the time crate to a released version with a fix.

Reference:
- NixOS/nixpkgs#332957
- rust-lang/rust#125319
- rust-lang/rust#99969
Copy link
Owner

@friedow friedow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-kenji a-kenji merged commit 05e6640 into main Aug 11, 2024
1 check passed
@a-kenji a-kenji deleted the fix/type-inference branch August 11, 2024 11:17
@a-kenji
Copy link
Collaborator Author

a-kenji commented Aug 11, 2024

Maybe we can tag a release in the next 1-2 weeks so that nixpkgs can pick it up?

@friedow
Copy link
Owner

friedow commented Aug 11, 2024

I'll release centerpiece right now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants