Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure incompatible versions of time are not allowed #3463

Closed
wants to merge 1 commit into from

Conversation

kornelski
Copy link
Contributor

PR Type

Other

Overview

Rust 1.80 broke compatibility with many versions of the time 0.3 crate. actix-web is one of the most popular crates using it, so bumping it here may help users avoid ever getting a broken time version, even if they have an older lockfile.

@robjtede
Copy link
Member

Isn't it just as easy to cargo update -p=time as it would be to cargo update -p=actix-web as would be needed to get this patch if released?

@kornelski
Copy link
Contributor Author

Yes, although it helps for cargo add.

@robjtede
Copy link
Member

robjtede commented Oct 1, 2024

I don't feel that the upside justifies an over-specified dependency.

@robjtede robjtede closed this Oct 1, 2024
@robjtede robjtede added A-web project: actix-web B-semver-norelease change that does not require a release labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web project: actix-web B-semver-norelease change that does not require a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants