Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create neovim plugins specific updater #342884

Closed
wants to merge 6 commits into from

Conversation

teto
Copy link
Member

@teto teto commented Sep 18, 2024

  • init neovim plugin updater
  • luarocks-packages-updater: convert into pyproject package
  • pluginupdate: move to its own folder
  • neovim-plugins-updater: 0.0.1
  • moved .flake8 close to lua upadter
  • fixup
  • luaPackages: update on 2024-09-16
  • renamed to nix_luarocks_updater
  • luaPackages: update on 2024-09-18
  • remove now unneeded override
  • luaPackages: update on 2024-09-18

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@PerchunPak
Copy link
Member

I am working now on reopening RFC 109 to standardize all updaters, but nice effort. I will look into it further later.

For now, could you describe design decisions made in this PR please? E.g. how did you solve the problem of two sources of truth that is described in #335931

teto and others added 6 commits September 24, 2024 23:25
wip

wip
wip

wip

fixed the luarocks updater: next is neovim's

fixed neovim updater
luaPackages: update on 2024-09-18

luaPackages: update on 2024-09-18

remove now unneeded override

luaPackages: update on 2024-09-18

luaPackages: update on 2024-09-18

luaPackages: update on 2024-09-18
@teto teto force-pushed the teto/move-neovim-plugins-updater branch from 2240720 to 07dcf1f Compare September 24, 2024 21:28
@teto teto mentioned this pull request Sep 24, 2024
13 tasks
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2024
@teto
Copy link
Member Author

teto commented Nov 19, 2024

this was too complex. #344320 is more promising.

@teto teto closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: lua 6.topic: vim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants