Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dooit: add maintainer kraanzu #345234

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

kraanzu
Copy link
Member

@kraanzu kraanzu commented Sep 29, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 29, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 29, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 30, 2024
@kraanzu kraanzu mentioned this pull request Sep 30, 2024
13 tasks
@kirillrdy kirillrdy changed the title Add maintainer kraanzu dooit: add maintainer kraanzu Sep 30, 2024
@kirillrdy
Copy link
Member

@ofborg build dooit

@khaneliman
Copy link
Contributor

@ofborg build dooit

it's a noop change?

@kirillrdy
Copy link
Member

@kirillrdy kirillrdy merged commit 6d6e3bf into NixOS:master Sep 30, 2024
35 of 36 checks passed
@khaneliman
Copy link
Contributor

@ofborg build dooit

it's a noop change?

and yet https://github.com/NixOS/nixpkgs/pull/345234/checks?check_run_id=30813124983

witch magic!

@khaneliman
Copy link
Contributor

@ofborg build dooit

it's a noop change?

and yet https://github.com/NixOS/nixpkgs/pull/345234/checks?check_run_id=30813124983

This actually led to me discovering a few things, thanks!

@kirillrdy
Copy link
Member

lol, and I've learned something too

dooit builds but dooit.tests fails, i guess in future I should have run the tests

@kraanzu
Copy link
Member Author

kraanzu commented Oct 1, 2024

Yep this was a breaking change made a few versions before (around 0.72 I guess). They have very frequent releases

I'll push a new version in a few days and stuff should work as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants