Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main.py: dont import tui for version check #192

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Sep 30, 2024

Short cut tui import for quicker version check with less unexpected side effects. Follow up to NixOS/nixpkgs#345234 (comment)

EDIT: maybe makes sense to leave this alone until proper pytests are in place to validate program functionality so we can still use the version check to validate the program.

@khaneliman khaneliman changed the base branch from main to develop September 30, 2024 23:08
Copy link
Member

@kraanzu kraanzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm...I thought it was already like this. Maybe in a diff branch. But thanks!

@kraanzu kraanzu merged commit f20fb90 into dooit-org:develop Oct 1, 2024
1 check failed
@khaneliman khaneliman deleted the version branch October 1, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants