github-runner: 2.319.1 -> 2.320.0

[kirillrdy]

https://github.com/actions/runner/releases/tag/v2.320.0

one patch failed to apply, replaced with substituteInPlace

happy to drop formatting changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[patka-123]

The release notes contain:

Add jq, git, unzip and curl to default packages installed actions/runner#3056

Upstream added those packages to their Dockerfile. Shouldn't we also pass in those packages?

[kirillrdy]

The release notes contain:

Add jq, git, unzip and curl to default packages installed actions/runner#3056

Upstream added those packages to their Dockerfile. Shouldn't we also pass in those packages?

after reading comments in actions/runner#3056, I am leaning towards no, but I will let maintainers decide

[veehaitch]

I am not strictly against it, but as far as I understand the Dockerfile has nothing to do with the VM images of the GitHub-hosted runners. They include tons of preinstalled software and we obviously don't want to include all that software for the NixOS module. If we add the tools mentioned, the question immediately arises as to why other programs are not important as well. Therefore, I'd rather refer people to services.github-runners.<name>.extraPackages.

[arianvp]

This needs backporting as Github Actions will block runners that are out of date

[github-actions]

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-346347-to-release-24.05 origin/release-24.05
cd .worktree/backport-346347-to-release-24.05
git switch --create backport-346347-to-release-24.05
git cherry-pick -x 930f9daf233910fa4b6f1442d51c9a7be15deed1 bf1088cf5adc6bfeafbeec96960cfa61a93d3c4b

[arianvp]

Unfortunately the formatting patches makes the backport not apply cleanly

[github-actions]

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-346347-to-release-24.05 origin/release-24.05
cd .worktree/backport-346347-to-release-24.05
git switch --create backport-346347-to-release-24.05
git cherry-pick -x 930f9daf233910fa4b6f1442d51c9a7be15deed1 bf1088cf5adc6bfeafbeec96960cfa61a93d3c4b