Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add jq, git, unzip and curl to default packages installed #3056

Merged
merged 11 commits into from
Aug 20, 2024

Conversation

onedr0p
Copy link
Contributor

@onedr0p onedr0p commented Dec 26, 2023

Hi 👋🏼

I am using this runner with the Actions Runner Controller

These three packages are used by a ton of actions on the marketplace. It would be nice if they were installed and ready for use instead of having to install them with apt-get on every single Github workflow. If using more than one job in a workflow you have to have a step to install these in each one.

I know you all probably want to keep a low footprint of installed tools but these are probably just as important as sudo for user experience.

Hi 👋🏼 

These packages are used in a ton of actions on the marketplace. It would be nice if they were installed and ready for use instead of having to install them with `apt-get` on every single Github workflow.
@onedr0p onedr0p requested a review from a team as a code owner December 26, 2023 19:35
@onedr0p onedr0p changed the title fix: add git and curl to default packages installed fix: add jq, git and curl to default packages installed Dec 27, 2023
@withinboredom
Copy link

Will also fix actions/actions-runner-controller#3222

@omri-shilton
Copy link

any update on this?

@dcardellino24
Copy link

as some people already asked, is there any update on this?

@onedr0p
Copy link
Contributor Author

onedr0p commented Feb 27, 2024

The silence from the action/runners maintainers is deafening 😭

@withinboredom
Copy link

There's probably some huge philosophical debate behind closed doors:

  • the practical: yeah, this makes sense
  • the minimalist: they'd have it be a clone of scratch if they could get away with it

images/Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Guillermo Caracuel <633810+gcaracuel@users.noreply.github.com>
@onedr0p onedr0p changed the title fix: add jq, git and curl to default packages installed fix: add jq, git, unzip and curl to default packages installed Mar 6, 2024
@withinboredom
Copy link

I'm starting to wonder if the project is maintained. I mean, I clearly see them merging PRs but only their own PRs and without much context/comments on them. They don't seem to be interested in community contributions or building this with the community.

@onedr0p
Copy link
Contributor Author

onedr0p commented Mar 7, 2024

It's probably based on business driven development, meaning paying customers who want changes are prioritized. 😢

@danitfk
Copy link

danitfk commented May 7, 2024

Honestly it seems to be community doesn't matter for them))

@withinboredom
Copy link

The decision behind our slim image was to:

provide a small image that can be used to execute workflows in case you don't need extra tools

Except you can't execute any workflows because not even git is installed... for a GitHub builder...

@onedr0p
Copy link
Contributor Author

onedr0p commented May 30, 2024

This is funny...
#3273

@onedr0p
Copy link
Contributor Author

onedr0p commented May 30, 2024

👋🏼 @TingluoHuang is this purposely getting ignored?

@omri-shilton
Copy link

any news on this?

@onedr0p
Copy link
Contributor Author

onedr0p commented Jul 28, 2024

@omri-shilton (or anyone else) if the company you work for has a support contract with GitHub, bring this up in a ticket. My assumptions are it doesn't look like individual contributors PRs are prioritized unless there's a push from a GitHub customer.

@mbmcmullen27
Copy link

There have been other issues created about how bare the self hosted runner image is. It doesn't seem like a priority for github. Doesn't seem like they're willing to budge on this unfortunately.

#3080

I think there was a discussion post about it somewhere too.

@withinboredom
Copy link

If I had a tinfoil hat 👽 at this point: they want your first jobs to fail so that you don't use self-hosted runners. We all know that a greater barrier to entry means less people will use it. /s

@nebuk89
Copy link

nebuk89 commented Jul 31, 2024

Sorry for the tumbleweeds, let me poke the team and get someone to look at this.

images/Dockerfile Outdated Show resolved Hide resolved
onedr0p and others added 2 commits July 31, 2024 10:42
Co-authored-by: Tingluo Huang <tingluohuang@github.com>
@onedr0p
Copy link
Contributor Author

onedr0p commented Jul 31, 2024

Updated.

@wwalters12
Copy link

We have to spend ~20s each build installing git - this would be such a great change 🙏

@onedr0p
Copy link
Contributor Author

onedr0p commented Aug 6, 2024

@nebuk89 @TingluoHuang any update?

@shaul75
Copy link

shaul75 commented Aug 13, 2024

instead of having to install them with apt-get on every single Github workflow. If using more than one job in a workflow you have to have a step to install these in each one.

@onedr0p why not use your own runner image with all the packages you need already installed?

@onedr0p
Copy link
Contributor Author

onedr0p commented Aug 13, 2024

I already do that but it wouldn't be required for me to maintain if the GitHub runner included Git by default.

@nebuk89
Copy link

nebuk89 commented Aug 19, 2024

I will follow up!

@TingluoHuang TingluoHuang merged commit e1fa1fc into actions:main Aug 20, 2024
10 checks passed
@onedr0p onedr0p deleted the patch-1 branch August 20, 2024 14:26
@withinboredom
Copy link

🥇

@GeunSam2
Copy link

GeunSam2 commented Sep 4, 2024

I really love this update!!

@mbelot007
Copy link

When will this change be included in a patch release v2.319.2? Still experiencing issues with this.

bo0tzz added a commit to immich-app/devtools that referenced this pull request Oct 4, 2024
bo0tzz added a commit to immich-app/devtools that referenced this pull request Oct 4, 2024
bo0tzz added a commit to immich-app/devtools that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.