Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: 3.30.5 -> 3.31.3 #363395

Merged
merged 1 commit into from
Jan 5, 2025
Merged

cmake: 3.30.5 -> 3.31.3 #363395

merged 1 commit into from
Jan 5, 2025

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Dec 8, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for cmake is: Cross-platform, open-source build system generator

meta.homepage for cmake is: https://cmake.org/

meta.changelog for cmake is: https://cmake.org/cmake/help/v3.31/release/3.31.html

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 3.31.2 with grep in /nix/store/hd4lsl5i5z6wamcs1spni9n13zik1nrq-cmake-3.31.2
  • found 3.31.2 in filename of file in /nix/store/hd4lsl5i5z6wamcs1spni9n13zik1nrq-cmake-3.31.2

Rebuild report (if merged into master) (click to expand)
57490 total rebuild path(s)

57489 package rebuild(s)

First fifty rebuilds by attrpath

ArchiSteamFarm
CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcprime
CuboCore.libcsys
DisnixWebService
Fabric
LAStools
LPCNet
MMA
OVMF
OVMF-cloud-hypervisor
OVMFFull
QuadProgpp
R
SDL
SDL1
SDL2
SDL2_Pango
SDL2_gfx
SDL2_image
SDL2_image_2_0
SDL2_image_2_6
SDL2_mixer
SDL2_mixer_2_0
SDL2_net
SDL2_sound
SDL2_ttf
SDL_Pango
SDL_audiolib
SDL_compat
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/hd4lsl5i5z6wamcs1spni9n13zik1nrq-cmake-3.31.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A cmake https://github.com/r-ryantm/nixpkgs/archive/316cbbd0bc9e0714d75993238e22f1010d67a548.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/316cbbd0bc9e0714d75993238e22f1010d67a548#cmake

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/hd4lsl5i5z6wamcs1spni9n13zik1nrq-cmake-3.31.2
ls -la /nix/store/hd4lsl5i5z6wamcs1spni9n13zik1nrq-cmake-3.31.2/bin


Pre-merge build results

NixPkgs review skipped


Maintainer pings

cc @ttuegel @LnL7 for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@r-ryantm r-ryantm changed the title cmake: 3.30.5 -> 3.31.2 cmake: 3.30.5 -> 3.31.3 Dec 29, 2024
@r-ryantm
Copy link
Contributor Author

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for cmake is: Cross-platform, open-source build system generator

meta.homepage for cmake is: https://cmake.org/

meta.changelog for cmake is: https://cmake.org/cmake/help/v3.31/release/3.31.html

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 3.31.3 with grep in /nix/store/viphrrivan80ly6gw36y9zbra6fwxn4k-cmake-3.31.3
  • found 3.31.3 in filename of file in /nix/store/viphrrivan80ly6gw36y9zbra6fwxn4k-cmake-3.31.3

Rebuild report (if merged into master) (click to expand)
57643 total rebuild path(s)

57642 package rebuild(s)

First fifty rebuilds by attrpath

ArchiSteamFarm
CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcprime
CuboCore.libcsys
DisnixWebService
Fabric
LAStools
LPCNet
MMA
OVMF
OVMF-cloud-hypervisor
OVMFFull
QuadProgpp
R
SDL
SDL1
SDL2
SDL2_Pango
SDL2_gfx
SDL2_image
SDL2_image_2_0
SDL2_image_2_6
SDL2_mixer
SDL2_mixer_2_0
SDL2_net
SDL2_sound
SDL2_ttf
SDL_Pango
SDL_audiolib
SDL_compat
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/viphrrivan80ly6gw36y9zbra6fwxn4k-cmake-3.31.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A cmake https://github.com/r-ryantm/nixpkgs/archive/152d7e78818519b2c775dd4fc39747a96eb42520.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/152d7e78818519b2c775dd4fc39747a96eb42520#cmake

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/viphrrivan80ly6gw36y9zbra6fwxn4k-cmake-3.31.3
ls -la /nix/store/viphrrivan80ly6gw36y9zbra6fwxn4k-cmake-3.31.3/bin


Pre-merge build results

NixPkgs review skipped


Maintainer pings

cc @ttuegel @LnL7 for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not see anything problematic in the release notes at a glance.

There are some new deprecations which we might want to forward to upstreams.

CMP0171 adds a ton of new warnings to evolution-data-server but it still builds.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 30, 2024
@emilazy emilazy merged commit 6788198 into NixOS:staging Jan 5, 2025
44 of 45 checks passed
@r-ryantm r-ryantm deleted the auto-update/cmake branch January 6, 2025 00:17
@trofi
Copy link
Contributor

trofi commented Jan 6, 2025

Bisect says this change broke python3Packages.editorconfig tests in staging as:

$ nix build --no-link -f. python3Packages.editorconfig
...
The following tests FAILED:
          2 - meta_multiline (Failed)
          3 - star_single_ML (Failed)
          4 - star_zero_ML (Failed)
          5 - star_multiple_ML (Failed)
          7 - star_after_slash_ML (Failed)
          8 - star_matches_dot_file_after_slash_ML (Failed)
        131 - tab_width_default_ML (Failed)
        132 - tab_width_default_indent_size_tab_ML (Failed)
        133 - indent_size_default_ML (Failed)
        136 - indent_size_default_with_tab_width_ML (Failed)
        137 - lowercase_values1_ML (Failed)
        138 - lowercase_values2_ML (Failed)
        141 - repeat_sections_ML (Failed)
        142 - basic_cascade_ML (Failed)
        148 - blank_lines_between_properties_ML (Failed)
        152 - spaces_before_middle_property_ML (Failed)
        154 - comment_between_props_ML (Failed)
        158 - octothorpe_comment_between_props_ML (Failed)
        172 - parent_and_current_dir_ML (Failed)
        190 - unset_indent_size_ML (Failed)

@trofi
Copy link
Contributor

trofi commented Jan 6, 2025

Possibly a matter of updating to a new version: editorconfig/editorconfig-core-py#51

@jtojnar
Copy link
Member

jtojnar commented Jan 6, 2025

The patches just appear to bump the deprecated cmake_minimum_required < 3.10: editorconfig/editorconfig-core-test#57 and editorconfig/editorconfig-core-test#53

Sounds like the package is promoting deprecation warnings to errors or something. Bumping it sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants