Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.editorconfig: 0.12.4 -> 0.17.0 #369288

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Dec 30, 2024

Diff: editorconfig/editorconfig-core-py@v0.12.4...v0.17.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 30, 2024
Copy link
Contributor

@trofi trofi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIxes editorconfig build for me on staging with breakage mentioned in #363395 (comment).

Thank you!

@trofi
Copy link
Contributor

trofi commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369288


x86_64-linux

✅ 57 packages built:
  • anime-downloader
  • anime-downloader.dist
  • copier
  • copier.dist
  • devtoolbox
  • diffoscope
  • diffoscope.dist
  • diffoscope.man
  • diffoscopeMinimal
  • diffoscopeMinimal.dist
  • diffoscopeMinimal.man
  • djlint
  • djlint.dist
  • garble
  • jsbeautifier (python312Packages.jsbeautifier)
  • jsbeautifier.dist (python312Packages.jsbeautifier.dist)
  • python312Packages.canals
  • python312Packages.canals.dist
  • python312Packages.cssbeautifier
  • python312Packages.cssbeautifier.dist
  • python312Packages.editorconfig
  • python312Packages.editorconfig.dist
  • python312Packages.mkdocs-mermaid2-plugin
  • python312Packages.mkdocs-mermaid2-plugin.dist
  • python313Packages.canals
  • python313Packages.canals.dist
  • python313Packages.cssbeautifier
  • python313Packages.cssbeautifier.dist
  • python313Packages.editorconfig
  • python313Packages.editorconfig.dist
  • python313Packages.jsbeautifier
  • python313Packages.jsbeautifier.dist
  • python313Packages.mkdocs-mermaid2-plugin
  • python313Packages.mkdocs-mermaid2-plugin.dist
  • tests.dotnet.final-attrs.check-output
  • tests.dotnet.final-attrs.output-matches-const
  • tests.dotnet.final-attrs.override-has-no-effect
  • tests.dotnet.final-attrs.override-modifies-output
  • tests.dotnet.structured-attrs.check-output
  • tests.dotnet.use-dotnet-from-env.fallback
  • tests.dotnet.use-dotnet-from-env.use-dotnet-path-env
  • tests.dotnet.use-dotnet-from-env.use-dotnet-root-env
  • tests.replaceVars.replaceVars
  • tests.replaceVars.replaceVars-succeeds-with-exemption
  • tests.substitute.legacySingleArg
  • tests.substitute.legacySingleReplace
  • tests.substitute.legacyString
  • tests.substitute.legacyVar
  • tests.substitute.substitutions
  • tests.testers.testEqualContents.emptyFileAndDir
  • tests.testers.testEqualContents.equalDir
  • tests.testers.testEqualContents.equalExe
  • tests.testers.testEqualContents.fileDiff
  • tests.testers.testEqualContents.fileMissing
  • tests.testers.testEqualContents.nonExistentPath
  • tests.testers.testEqualContents.unequalExe
  • tests.testers.testEqualContents.unequalExeInDir

Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream diff looks reasonable.

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 6, 2025
@NickCao NickCao merged commit 9ee7a88 into NixOS:master Jan 6, 2025
42 of 43 checks passed
@NickCao NickCao deleted the editorconfig branch January 6, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants