Provide all the binaries needed by the vim-go plugin #49669

kalbasit · 2018-11-03T05:11:59Z

Motivation for this change

The vim-go plugin requires some external binaries to function properly, this change patches the plugin with the PATH that provides all the binaries it needs.

I tested the plugin with:

nix-shell -I nixpkgs=. --pure -p 'with import <nixpkgs> {}; neovim.override { configure = { vam.pluginDictionaries = [ "vim-go" ]; }; }'

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

replaces #49498

…be functional

kalbasit · 2018-11-03T05:15:48Z

not sure if this works, I'll try anyway

@GrahamcOfBorg build -E 'with import {}; neovim.override { configure = { vam.pluginDictionaries = [ "vim-go" ]; }; }'

GrahamcOfBorg · 2018-11-03T05:16:03Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: -E, 'with, import, , {};, neovim.override, {, configure, =, {, vam.pluginDictionaries, =, [, "vim-go", ];, };, }'

Partial log (click to expand)


Cannot nix-instantiate `];' because:
error: attribute '];' in selection path '];' not found

Cannot nix-instantiate `};' because:
error: attribute '};' in selection path '};' not found

Cannot nix-instantiate `}'' because:
error: attribute '}'' in selection path '}'' not found

GrahamcOfBorg · 2018-11-03T05:16:46Z

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: -E, 'with, import, , {};, neovim.override, {, configure, =, {, vam.pluginDictionaries, =, [, "vim-go", ];, };, }'

Partial log (click to expand)


Cannot nix-instantiate `];' because:
error: attribute '];' in selection path '];' not found

Cannot nix-instantiate `};' because:
error: attribute '};' in selection path '};' not found

Cannot nix-instantiate `}'' because:
error: attribute '}'' in selection path '}'' not found

aarch64 cpus are going to break on pkgsi686Linux packages. See this error: https://hydra.nixos.org/build/82962379/

matthewbauer · 2018-11-03T05:48:39Z

@GrahamcOfBorg eval

Mic92 · 2018-11-04T17:16:54Z

pkgs/misc/vim-plugins/overrides.nix

@@ -9,6 +9,12 @@
 , languagetool
 , Cocoa, CoreFoundation, CoreServices
 , buildVimPluginFrom2Nix
+
+# vim-go denpencies


Suggested change

# vim-go denpencies

# vim-go dependencies

Mic92 · 2018-11-04T17:19:19Z

@GrahamcOfBorg build asmfmt deadcode errcheck go-check go-tools goconst gocyclo gogetdoc gometalinter gosec iferr impl ineffassign interfacer maligned reftools unconvert vimPlugins.vim-go

GrahamcOfBorg · 2018-11-04T17:22:51Z

Success on x86_64-darwin (full log)

Attempted: asmfmt, deadcode, errcheck, go-check, go-tools, goconst, gocyclo, gogetdoc, gometalinter, gosec, iferr, impl, ineffassign, interfacer, maligned, reftools, unconvert, vimPlugins.vim-go

Partial log (click to expand)

/nix/store/q7dx24481vanmh8mw8aaclfvnj28fxxv-gometalinter-2.0.11-bin
/nix/store/6ga4s4vxg7ns14s2gfhmpmlr99hak8qy-gosec-1.1.0-bin
/nix/store/0paz426p9jnmlgbsl2lqy1l6sdkc34ws-iferr-unstable-2018-06-15-bin
/nix/store/cc63rixcsyisvm8gmnqg7cqs9avnynwi-impl-unstable-2018-02-27-bin
/nix/store/ks9w7hx7gxhfdak33qi6dv826xb111jd-ineffassign-unstable-2018-09-09-bin
/nix/store/8n4fkrk4imrfgn56rw1nkb8pqmaq8rkn-interfacer-unstable-2018-08-31-bin
/nix/store/lc5vlna36dxrq93pr6pvprywfb8rf0zr-maligned-unstable-2018-07-07-bin
/nix/store/zyrhw9gmcfg3pbdfk8s423a9y524wr72-reftools-unstable-2018-09-14-bin
/nix/store/a3vsyqys55vrx0lkcdz82v8r0qfza091-unconvert-unstable-2018-07-03-bin
/nix/store/j1pzmwkw5cb9ps6w0mvlfrzfsyh3wmxy-vimplugin-vim-go-2018-10-23

GrahamcOfBorg · 2018-11-04T17:24:22Z

Success on x86_64-linux (full log)

Attempted: asmfmt, deadcode, errcheck, go-check, go-tools, goconst, gocyclo, gogetdoc, gometalinter, gosec, iferr, impl, ineffassign, interfacer, maligned, reftools, unconvert, vimPlugins.vim-go

Partial log (click to expand)

/nix/store/bxc8rgn3yh560zfakhf1nnmcv22i5yx1-gometalinter-2.0.11-bin
/nix/store/l2xa17z1dsbyqidhyd6dm3gpdswj87vl-gosec-1.1.0-bin
/nix/store/rdik315xpy4xk7w265yxzribznrk7ca8-iferr-unstable-2018-06-15-bin
/nix/store/l9986i22zc17dg86a0ykpkvpp056ahrl-impl-unstable-2018-02-27-bin
/nix/store/f71m2hrs3l7m4aikw009cvnsmzdz5ask-ineffassign-unstable-2018-09-09-bin
/nix/store/9ci2mkqa6cw6qgi0zvg722dij3dax71h-interfacer-unstable-2018-08-31-bin
/nix/store/kgxybca667fnaxm8bfd3qlr0njy94ddp-maligned-unstable-2018-07-07-bin
/nix/store/wgl0pchl0l6hyshxrlrgj3kllglh4wf9-reftools-unstable-2018-09-14-bin
/nix/store/g0c6a18xjy00fs6vgsgj3dh01biviyhf-unconvert-unstable-2018-07-03-bin
/nix/store/26b596vmmlfg5d43skb7vq83393ycm5z-vimplugin-vim-go-2018-10-23

GrahamcOfBorg · 2018-11-04T17:26:18Z

Success on aarch64-linux (full log)

Attempted: asmfmt, deadcode, errcheck, go-check, go-tools, goconst, gocyclo, gogetdoc, gometalinter, gosec, iferr, impl, ineffassign, interfacer, maligned, reftools, unconvert

The following builds were skipped because they don't evaluate on aarch64-linux: vimPlugins.vim-go

Partial log (click to expand)

/nix/store/8dvmf8l5xrs820r6fplg44qxqx82aib3-gogetdoc-unstable-2018-10-25-bin
/nix/store/r897rapc6mlrq3x40p85l9gl1jp0nak8-gometalinter-2.0.11-bin
/nix/store/dwdkmwi09lj5glxh5ig1xxp3kaqyrhjm-gosec-1.1.0-bin
/nix/store/qmb1pvcil1qp9njq4xf76df27z9wldzm-iferr-unstable-2018-06-15-bin
/nix/store/zzh7a3dqp6lrkg9hk7gjkksq3vydkdha-impl-unstable-2018-02-27-bin
/nix/store/44fqwaw5zc4h2hlc8dg9317c07gmwxrw-ineffassign-unstable-2018-09-09-bin
/nix/store/pwn87nfqwn3ym88f9ax2ynddg1gd3b7v-interfacer-unstable-2018-08-31-bin
/nix/store/sd7wd68iipdaxdz0zlqqli9x54v80pcy-maligned-unstable-2018-07-07-bin
/nix/store/yj4yj1clms0vdp7rf7v183dbmk4j0xhk-reftools-unstable-2018-09-14-bin
/nix/store/fxq0mvlk87j3ibsvfhjfl2hl2jjdcajg-unconvert-unstable-2018-07-03-bin

kalbasit added 18 commits November 2, 2018 21:58

asmfmt: init at 1.1

126e64e

errcheck: init at 1.1.0

6d7413e

reftools: init at unstable 2018-09-14

f6e78e4

gogetdoc: init at unstable 2018-10-25

f5e4939

deadcode: init at unstable 2016-07-24

9795ad3

go-tools: init at 2017.2.2

d225933

ineffassign: init at unstable 2018-09-09

df46a94

unconvert: init at unstable 2018-07-03

63d9863

goconst: init at 1.1.0

fe83c5c

go-check: init unstable at 2018-09-12

f10fcf2

gocyclo: init unstable at 2015-02-08

1efe4d9

interfacer: init at unstable 2018-08-31

ed31a46

maligned: init unstable at 2018-07-07

cfa5c7f

gosec: init at 1.1.0

a1faa70

gometalinter: init at 2.0.11

6a09bfc

impl: init unstable at 2018-02-27

fce50a7

iferr: init unstable at 2018-06-15

e2355c6

vim-plugins: vim-go: provide the binaries required for the plugin to …

e09e529

…be functional

GrahamcOfBorg added 6.topic: vim 8.has: documentation labels Nov 3, 2018

kalbasit referenced this pull request Nov 3, 2018

stage.nix: pkgsi686Linux only works on x86 family

78ca6d8

aarch64 cpus are going to break on pkgsi686Linux packages. See this error: https://hydra.nixos.org/build/82962379/

GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 3, 2018

Mic92 reviewed Nov 4, 2018

View reviewed changes

Mic92 merged commit 2a3aa76 into NixOS:master Nov 4, 2018

kalbasit mentioned this pull request Nov 6, 2018

vimPlugins: vim-go: make gocode, gocode-mod and keyify available to it #49815

Merged

9 tasks

kalbasit mentioned this pull request Nov 15, 2018

vimPlugins.vim-go: use the correct motion derivation for the dependency #50381

Merged

9 tasks

kalbasit deleted the nixpkgs_provide-binaries-for-vim-go branch May 18, 2019 19:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide all the binaries needed by the vim-go plugin #49669

Provide all the binaries needed by the vim-go plugin #49669

kalbasit commented Nov 3, 2018 •

edited

Loading

kalbasit commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

matthewbauer commented Nov 3, 2018

Mic92 Nov 4, 2018

Mic92 commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

Provide all the binaries needed by the vim-go plugin #49669

Provide all the binaries needed by the vim-go plugin #49669

Conversation

kalbasit commented Nov 3, 2018 • edited Loading

Motivation for this change

Things done

kalbasit commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

GrahamcOfBorg commented Nov 3, 2018

matthewbauer commented Nov 3, 2018

Mic92 Nov 4, 2018

Choose a reason for hiding this comment

Mic92 commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

GrahamcOfBorg commented Nov 4, 2018

kalbasit commented Nov 3, 2018 •

edited

Loading