vimPlugins: vim-go: make gocode, gocode-mod and keyify available to it #49815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build gocode gocode-gomod vimPlugins.vim-go |
GrahamcOfBorg
added
8.has: package (new)
|
Success on x86_64-linux (full log) Attempted: gocode, gocode-gomod Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gocode, gocode-gomod Partial log (click to expand)
|
Mic92
reviewed
Nov 6, 2018
| @@ -261,6 +261,9 @@ with generated; | |||
| asmfmt | |||
| delve | |||
| errcheck | |||
| go-tools | |||
| gocode | |||
| gocode-gomod | |||
There was a problem hiding this comment.
What does gocode-gomode? It looks a bit like gocode.
There was a problem hiding this comment.
I was taken by this as well. gocode-gomod is a fork of gocode with support for Go modules. Unfortunately, neither project can replace the other!
See gocode README https://github.com/mdempsky/gocode#githubcommdempskygocode
There was a problem hiding this comment.
Is vim-go smart enough to switch between the too?
|
Success on x86_64-linux (full log) Attempted: gocode, gocode-gomod, vimPlugins.vim-go Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gocode, gocode-gomod The following builds were skipped because they don't evaluate on aarch64-linux: vimPlugins.vim-go Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a continuation of #49669, it seems that I have missed the gocode-gomod binary and I forgot to add gocode and go-tools to the vim-go path.
With regards to the
sedchange, initially, I patched go#path#CheckBinPath() which is called anytime a binary is called. However, there's also this call left unpached that can cause confusion if the user runs:GoInstallBinariesas it won't see the nix-store paths. In this PR, I decided to patch go#config#BinPath() which is called by any call out to a binary. As an added bonus, this patch patches the default go_bin_path, so a user can simplylet g:go_bin_path="..."from the vimrc to override it.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc @Mic92