Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stylize Pantheon #66136

Merged
merged 5 commits into from
Aug 6, 2019
Merged

stylize Pantheon #66136

merged 5 commits into from
Aug 6, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Finally got around to fixing how these expressions kinda looked weird
(#48637 (comment) #48637 (comment))

stuff like d15e904 were additional cleanups after taking a good look.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: pantheon The Pantheon desktop environment 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Aug 5, 2019
@worldofpeace
pantheon: stylize expressions
0b59f42 
The same way we want them in GNOME in nixpkgs.
Didn't touch the greeter expression because I have
a branch where it's already rewritten.
@worldofpeace
pantheon.updateScript: add a throw
47a9e87
@worldofpeace worldofpeace merged commit 0f6faf6 into NixOS:master Aug 6, 2019
@worldofpeace worldofpeace deleted the pantheon/reponame branch August 6, 2019 16:04
@worldofpeace worldofpeace mentioned this pull request Aug 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@worldofpeace