-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] isolate import cells #653
Labels
Comments
At the time of opening this issue these are the notebooks in main:
If you want to contribute please comment the name of the notebook(s) that you want to work on. The process consists of:
import sys
from execnb.nbio import read_nb
from nbdev.processors import FilterDefaults
fname = sys.argv[1]
nb = read_nb(fname)
FilterDefaults()(nb) and then run it like:
|
I've gone through all the notebooks. The above PR has the required changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
nbdev runs cells that contain import statements when building the docs, so when we have more code in there we incur in an unnecessary cost and it takes more time to build them, which can slow down development when previewing locally and also takes longer to deploy when pushing new commits.
We should isolate all cells that contain import statements to have only that, as is suggested here.
Link
No response
The text was updated successfully, but these errors were encountered: