Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolated import cells [Issue #653] #691

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

patrick-dd
Copy link
Contributor

Addressing issue #653

Have isolated input cells for all notebooks that require isolation.

All unmodified notebooks in the list on this page don't require work.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2023

CLA assistant check
All committers have signed the CLA.

@jmoralez
Copy link
Member

Hey @patrick-dd, thanks a lot for working on this! I just have a small request, if the original cell has a #| hide in it, can you please make sure that the new cell with the imports also has it? I see you carried them over in some of the cells but not all.

@patrick-dd
Copy link
Contributor Author

@jmoralez can do

@patrick-dd
Copy link
Contributor Author

I believe that should do it

@jmoralez jmoralez linked an issue Nov 10, 2023 that may be closed by this pull request
@jmoralez
Copy link
Member

This is awesome! You can see the time to build the docs went down from almost 6 minutes (yesterday's run) to around 2.5 minutes in this PR. Also all the warnings are gone. Thanks a lot for this!

@jmoralez jmoralez merged commit 1a84462 into Nixtla:main Nov 10, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] isolate import cells
3 participants