fix: accept missing mix hashes in remote blocks #516
Conversation
🦋 Changeset detectedLatest commit: 2e40c98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fvictorio
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
fvictorio
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
crates/edr_evm/src/block/remote.rs
Outdated
| @@ -79,7 +79,7 @@ impl RemoteBlock { | |||
| gas_used: block.gas_used, | |||
| timestamp: block.timestamp, | |||
| extra_data: block.extra_data, | |||
| mix_hash: block.mix_hash.ok_or(CreationError::MissingMixHash)?, | |||
| mix_hash: block.mix_hash.unwrap_or_default(), | |||
There was a problem hiding this comment.
I think we should add a GitHub issue and TODO here to indicate that this should be reverted once we have multi-chain support.
Then we (or someone else) can add an implementation for this particular chain.
There was a problem hiding this comment.
Done, thanks.
Can you re-review this? I had to solve a merge conflict and it was pretty straightforward, but it wouldn't hurt to double-check.
|
Thank you for the fix! Do you have any idea when you plan to release it? |
fvictorio
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
|
@jeremyjams I guess we'll merge this today, and might release it later this week.
Correct. |
|
Hi, do you have any update on that? |
|
@jeremyjams sorry for taking longer than I expected, we just released this: https://github.com/NomicFoundation/edr/releases/tag/%40nomicfoundation%2Fedr%400.4.1 To upgrade to this version immediately, you can remove your You can verify that you’re using the latest version by running the following command: |
|
Hello @fvictorio no problem, thank you for this release and your previous message 🙏 (I'm sadly now facing another issue #536) |
See NomicFoundation/hardhat#5266 (comment)
I didn't add a test for this because neither Infura nor Alchemy support that creditcoin chain, and I don't think we should use public RPC URLs in our tests, since they don't tend to be very robust.