Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove hardfork restriction on eth_getLogs #5087

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix: remove hardfork restriction on eth_getLogs #5087

merged 2 commits into from
Apr 5, 2024

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Apr 5, 2024 •
edited
Loading

@Wodann Wodann added the area:edr label Apr 5, 2024
@Wodann Wodann self-assigned this Apr 5, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2fc5a18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/edr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 1:50pm

@Wodann Wodann temporarily deployed to github-action-benchmark April 5, 2024 12:29 — with GitHub Actions Inactive
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Apr 5, 2024
@Wodann Wodann marked this pull request as ready for review April 5, 2024 13:16
@Wodann Wodann requested review from fvictorio and agostbiro April 5, 2024 13:16
@Wodann Wodann linked an issue Apr 5, 2024 that may be closed by this pull request
eth_getLogs availability determination is incorrect NomicFoundation/edr#361
Closed
agostbiro
agostbiro approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@agostbiro agostbiro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a hardfork restriction for eth_getLogs in the EthereumJS branch, so I agree that the right move is to remove it 👍

@Wodann Wodann had a problem deploying to github-action-benchmark April 5, 2024 13:48 — with GitHub Actions Error
@Wodann Wodann temporarily deployed to github-action-benchmark April 5, 2024 13:49 — with GitHub Actions Inactive
@Wodann
Copy link
Member Author

Wodann commented Apr 5, 2024

I added a test to validate it, for completeness.

@Wodann Wodann merged commit 62e28ad into main Apr 5, 2024
43 checks passed
@Wodann Wodann deleted the fix/get-logs branch April 5, 2024 14:14
@jeremyjams
Copy link

Hello @Wodann thank you for the fix! @fvictorio I'm facing this issue, could release this work in a patch 🙏 (2.21.1 or 2.22.3) ?

@Wodann
Copy link
Member Author

Wodann commented Apr 8, 2024 •
edited
Loading

Hello @Wodann thank you for the fix! @fvictorio I'm facing this issue, could release this work in a patch 🙏 (2.21.1 or 2.22.3) ?

You're most welcome.

We haven't released a new version of hardhat yet, but did release a version of EDR with the bug fix. You can force the EDR dependency to be upgraded by removing the lockfile constraint. That should ensure that Hardhat's underlying EDR dependency is updated to the latest :)

@jeremyjams
Copy link

Smart, thanks 😎 !

@jeremyjams jeremyjams mentioned this pull request Jun 17, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agostbiro agostbiro agostbiro approved these changes

@fvictorio fvictorio Awaiting requested review from fvictorio

Assignees

@Wodann Wodann

Labels
area:edr status:ready This issue is ready to be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eth_getLogs availability determination is incorrect
3 participants
@Wodann @jeremyjams @agostbiro