Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2025-01-14 #626

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Release 2025-01-14 #626

merged 8 commits into from
Jan 14, 2025

Conversation

kanej
Copy link
Member

@kanej kanej commented Jan 14, 2025

0.8.8 - 2025-01-14

Added

  • Add Solidity Survey 2024 popup (#625)

Fixed

  • Scan additional forge path on Windows for formatting commands, thanks @akshatmittal (#515)

Changed

  • Add telemetry diagnostics around formatting (#622)

akshatmittal and others added 7 commits December 13, 2024 16:17
Formatting has moved to the server side. We have added Sentry
transaction monitoring to the top level `onDocumentFormatting` call.

There are separate subspans on the Sentry transaction for Forge and
Prettier.

Resolves #622.
We should run under Node 20 as that is the version currently used by
VSCode.
* Typo fix in Title Update SpecifyVisibility.ts

* test: update tests with spelling fix for visibility

---------

Co-authored-by: John Kane <john@kanej.me>
* chore: add the solidity survery 2024 popup

* Update showSoliditySurveyPopup.ts

Co-authored-by: John Kane <john@kanej.me>

---------

Co-authored-by: John Kane <john@kanej.me>
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 14, 2025
Update the package version and changelog for the `0.8.8 - 2025-01-14` release.
@kanej kanej force-pushed the release/2025-01-14 branch from ea4dce8 to 500b058 Compare January 14, 2025 16:58
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 54.52%. Comparing base (0d2aa09) to head (500b058).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...er/src/services/formatting/onDocumentFormatting.ts 0.00% 27 Missing ⚠️
...rver/src/frameworks/Foundry/resolveForgeCommand.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   54.65%   54.52%   -0.13%     
==========================================
  Files         226      226              
  Lines        5187     5199      +12     
  Branches      800      800              
==========================================
  Hits         2835     2835              
- Misses       2115     2127      +12     
  Partials      237      237              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanej kanej merged commit 1ddb6d7 into main Jan 14, 2025
5 of 7 checks passed
@kanej kanej deleted the release/2025-01-14 branch January 14, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants