Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add the solidity survery 2024 popup #625

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

galargh
Copy link
Member

@galargh galargh commented Jan 14, 2025

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This is a follow-up to NomicFoundation/hardhat#6133

It adds the solidity survey popup similarly to how it was done in #312

@galargh galargh requested review from kanej and alcuadrado January 14, 2025 08:23
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.52%. Comparing base (0e5fdf6) to head (bf1e646).
Report is 1 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #625   +/-   ##
============================================
  Coverage        54.52%   54.52%           
============================================
  Files              226      226           
  Lines             5199     5199           
  Branches           800      800           
============================================
  Hits              2835     2835           
  Misses            2127     2127           
  Partials           237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanej kanej force-pushed the solidity-survey-2024 branch from 49bf332 to 2f73701 Compare January 14, 2025 10:55
Co-authored-by: John Kane <john@kanej.me>
@kanej kanej merged commit c572b8a into development Jan 14, 2025
11 checks passed
@kanej kanej deleted the solidity-survey-2024 branch January 14, 2025 13:08
@kanej kanej mentioned this pull request Jan 14, 2025
kanej added a commit that referenced this pull request Jan 14, 2025
* chore: add the solidity survery 2024 popup

* Update showSoliditySurveyPopup.ts

Co-authored-by: John Kane <john@kanej.me>

---------

Co-authored-by: John Kane <john@kanej.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants