chore: restore the solidity survey message (2024) #6133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b1dfb90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I also found NomicFoundation/hardhat-vscode#312 in the vscode repo. Should we restore it there, too? |
galargh
commented
Jan 10, 2025
galargh
commented
Jan 10, 2025
| @@ -372,15 +372,15 @@ function showStarOnGitHubMessage() { | |||
| } | |||
|
|
|||
| export function showSoliditySurveyMessage() { | |||
| if (new Date() > new Date("2024-01-07 23:39")) { | |||
| if (new Date() > new Date("2025-01-31 23:39")) { | |||
There was a problem hiding this comment.
I set the end date to the end of the month. My thinking was that we can extend it if it's still running beyond that point.
|
Looks good! Can we also update this? https://github.com/NomicFoundation/hardhat/blob/main/docs/src/config.ts#L29 |
galargh
force-pushed
the
solidity-survey-2024
branch
from
d064dee to
b1dfb90
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during the sync, I'm reenabling the Solidity Survey message.