eth_signTypedData incompatible with ethers _signTypedData

[thegostep]

const permission = await ethers.provider
    .getSigner(ownerAddress)
    ._signTypedData(domain, types, value)

[ricmoo]

Does hard hat implement the eth_signTypedData_v4 JSON-RPC method?

[thegostep]

Their docs show they support eth_signTypedData

https://hardhat.org/hardhat-network/#supported-methods

[thegostep]

It seems like it uses eth_signTypedData_v4 under the hood: https://github.com/nomiclabs/hardhat/blob/4532f4c742ca9d5055c1aa83346306354ebf1eed/packages/hardhat-core/src/internal/core/providers/accounts.ts#L72-L84

[ricmoo]

I don’t think that call is final yet, so they may need to at the very least make an alias to the _v4 variant that other clients use. Otherwise it is too hard to tell what parameters to pass to the function. Ethers only supports the v4 parameters description and has no intention of supporting legacy versions of EIP-712...

Do you know what parameter description they are using for that call? Is it v4 compatible?

[ricmoo]

Their string matching against the method name is wrong though, as it is checking for eth_signTypedData. So that if condition is skipped.