Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON-RPC eth_signTypedData_v4 method to Hardhat Network. #1189

Merged
merged 8 commits into from
Feb 9, 2021
Merged

Add JSON-RPC eth_signTypedData_v4 method to Hardhat Network. #1189

merged 8 commits into from
Feb 9, 2021

Conversation

scnale
Copy link
Contributor

@scnale scnale commented Jan 20, 2021 •
edited
Loading

This pull request:

  • Adds JSON-RPC method eth_signTypedData_v4 and implements it with signTypedData_v4 of eth-sig-util.
    • Its implementation mimics MetaMask's. It attempts to parse the typed message parameter as a JSON if it is a string.
  • Modifies the JSON-RPC method eth_signTypedData to mark it as not supported.
  • Adds JSON-RPC method eth_signTypedData_v3 and marks it as not supported.
  • Adds method _signTypedData for SignerWithAddress in hardhat-ethers.
  • Adds test in hardhat-ethers for SignerWithAddress._signTypedData.

Context: EIP712 early implementation.

@scnale scnale force-pushed the feature/eth-signTypedData-v4 branch from a29fec8 to af70584 Compare January 20, 2021 03:31
@scnale scnale mentioned this pull request Jan 20, 2021
Closed
@fvictorio fvictorio mentioned this pull request Jan 25, 2021
Closed
@scnale scnale linked an issue Jan 25, 2021 that may be closed by this pull request
eth_signTypedData incompatible with ethers _signTypedData #1199
Closed
@scnale
Remove eth_signTypedData JSON-RPC API.
3ec7815 
This marks it as unsupported.
@scnale
Add _signTypedData method to SignerWithAddress in hardhat-ethers.
c59e59b 
This restricts the type of the parameter for the creation of
`SignerWithAddress` to an `ethers.provider.JsonRpcSigner`
instead of an `ethers.Signer`.
@scnale scnale linked an issue Feb 1, 2021 that may be closed by this pull request
signer.signTypedData is not defined. #1108
Closed
@fvictorio fvictorio modified the milestones: hardhat-core@2.0.9, hardhat-ethers@2.0.2 Feb 9, 2021
@fvictorio fvictorio merged commit f604e23 into master Feb 9, 2021
@fvictorio fvictorio deleted the feature/eth-signTypedData-v4 branch February 9, 2021 18:24
@nlordell nlordell mentioned this pull request Mar 23, 2021
Merged
@spalladino spalladino mentioned this pull request Mar 30, 2021
Merged
jacobrosenthal pushed a commit to jacobrosenthal/hardhat that referenced this pull request Apr 29, 2021
@spalladino @jacobrosenthal
Update docs on supported flavor of signTypedData
a8e966f 
Vanilla `eth_signTypedData` was marked as unsupported in NomicFoundation#1189, in favor of the v4 version. This PR updates the docs to reflect that.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fvictorio fvictorio fvictorio left review comments

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
hardhat-core@2.0.9
Development

Successfully merging this pull request may close these issues.

eth_signTypedData incompatible with ethers _signTypedData signer.signTypedData is not defined.
3 participants
@scnale @alcuadrado @fvictorio