Upgrade ethereumjs fork #3153
Upgrade ethereumjs fork #3153
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 191c8eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for submitting this PR! Unfortunately, it has some linter errors, so we can't merge it yet. Can you please fix them? Running yarn |
| @@ -1961,6 +1955,12 @@ Hardhat Network's forking functionality only works with blocks from at least spu | |||
| return new TransactionExecutionError("Transaction ran out of gas"); | |||
| } | |||
|
|
|||
| if (error.error === ERROR.OUT_OF_GAS) { | |||
| // if the error is an out of gas, we ignore the inferred error in the | |||
There was a problem hiding this comment.
This feels a bit wrong, but it better reflects the previous behavior. In a previous commit I was also doing this here:
if (stackTrace !== undefined) {
return encodeSolidityStackTrace(
"Transaction ran out of gas",
stackTrace
);
}But that made some tests fail. For example, there is a test that generates an OOG for a tx that calls a precompile. The expected error is "out of gas" but with that change it became "call to pre-compile failed", which is arguably worse.
There's probably a better solution here, like expanding OOGs with more information ("out of gas during call to precompile", for example), but that's out of scope for this PR.
There was a problem hiding this comment.
Let's settle for this for now
No description provided.