-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support ESM test running via the test task #3156
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This issue is also being tracked on Linear. We use Linear to manage our development process, but we keep the conversations on Github. LINEAR-ID: f7739f98-fb6e-400e-ad17-25ffd7215590 |
Thanks for submitting this PR! Unfortunately, it has some linter errors, so we can't merge it yet. Can you please fix them? Running yarn |
I'm not sure why these tests are failing, but I'll look into it. |
Read the comment in `test/builtin-task/test.ts` to understand why there are so many changes in this commit.
This builds upon #3155 to support loading ESM tests within a
"type": "module"
when using hardhat in commonjs mode. It requires the.cjs
support from #3155 and then a one-line change to make mocha attempt to load ESM modules.I can rebase this when the other PR lands to just the last commit (check that out for the smaller diff).
I'm getting some parallel test failures, but those seem to exist for the CJS runs currently (maybe related to #3153?)