Fix #1978 - ability to deploy to networks behind a corporate proxies

[umakanth-fmr]

• Because this PR includes a bug fix, relevant tests have been included.
• Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
• [] I didn't do anything of this.

---

This PR addresses the issue with connecting to 3rd party networks behind corporate proxy. Currently undici Pool's does not support proxy. (nodejs/undici#1270).

We patched our local harhat to make it work.

Relevant issues on hardhat issue tracker.

#1978

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3ac8801

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
hardhat	✅ Ready (Inspect)	Visit Preview	Dec 6, 2022 at 8:13PM (UTC)
hardhat-storybook	✅ Ready (Inspect)	Visit Preview	Dec 6, 2022 at 8:13PM (UTC)

[github-actions]

This issue is also being tracked on Linear.

We use Linear to manage our development process, but we keep the conversations on Github.

LINEAR-ID: f06ca137-d6a5-4478-8920-9e47e5e8f233

[umakanth-fmr]

Pinging @fvictorio

[bolabola]

same error!!

[umakanth-fmr]

same error!!

What is the error ?

[bolabola]

same error!!

What is the error ?
try this int hardhat.config.ts
import { setGlobalDispatcher, ProxyAgent, Agent } from "undici"; const proxyAgent = new ProxyAgent("http://127.0.0.1:1087"); setGlobalDispatcher(proxyAgent);

[umakanth-fmr]

GlobalDispatcher does not work on specific proxies. This PR looks at HTTP_PROXY/HTTPS_PROXY and it sets ProxyAgent for connection. undici connection pools does not support proxy yet.

[umakanth-fmr]

Any update on this PR @fvictorio ?

[fvictorio]

Hey @umakanth-fmr, I haven't had time to review this yet, sorry 😞

I skimmed the PR's code and it looks good, but since this is a very sensitive change, I'll need to make a careful review before merging it.

[fvictorio]

Hey @umakanth-fmr, I ended up going for a somewhat different approach in #3432. The main difference is that I'm using a single environment variable, http_proxy. I also implemented better support for that variable in Hardhat core.

I'm going to close this PR in favor of that one. Thanks again and sorry for not merging yours.

[fvictorio]

@gitpoap-bot @umakanth-fmr deserves a gitpoap

[gitpoap-bot]

Congrats, @umakanth-fmr ! You've earned a GitPOAP for your contribution!

GitPOAP: 2022 Hardhat Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.