Improve proxy support #3432
Merged
Improve proxy support #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a3c6ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
fvictorio
force-pushed
the
improve-proxy-support
branch
from
03d5c2f
to
24137f5
Compare
|
@fvictorio , any tentative timeline or release this PR planned ? |
|
Can't promise a date but hopefully soon? It will almost surely be included in our next release. |
alcuadrado
reviewed
Feb 8, 2023
alcuadrado
approved these changes
Feb 8, 2023
Co-authored-by: Patricio Palladino <email@patriciopalladino.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
http_proxyenvironment variable both for downloading the compiler and for the HTTP provider. This means that both forking and connecting to networks via JSON-RPC should use the proxy.http_proxyinhardhat-etherscan.As part of this, I'm technically introducing a breaking change: the
HTTP_PROXYandHTTPS_PROXYvariables don't work anymore for the compiler download. The first one (all uppercase) is not the most commonly used, for fun historical reasons. And the second one is misleading: we use the same proxy for both http and https.