Propagate subprocess error #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 21, 2023 10:00
skeleton logging. The current error propagation leaks the error code from the command module up through the layers, even though the "get information" layer need not run any subcommands. This can be fixed later if we start going directly to /proc for information.
skeleton logging. The current error propagation leaks the error code from the command module up through the layers, even though the "get information" layer need not run any subcommands. This can be fixed later if we start going directly to /proc for information.
…t-hansen/sonar into propagate_subprocess_error
|
Tests fail because the integration environment does not have traceroute, which is a command I used to trigger a timeout. Will look for something else. |
|
I've concluded I really don't understand how patch stacks are supposed to work with git, I'll close this PR and resubmit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #53. This sits on top of the rebased AMD patch.