Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate subprocess error #54

Closed
wants to merge 7 commits into from
Closed

Propagate subprocess error #54

wants to merge 7 commits into from

Commits on Jun 21, 2023

  1. Extract AMD GPU info

    Lars T Hansen committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0527908 View commit details
    Browse the repository at this point in the history

  2. For #53: Propagate errors from the command module, and implement some 

    skeleton logging.

The current error propagation leaks the error code from the command
module up through the layers, even though the "get information" layer
need not run any subcommands.  This can be fixed later if we start
going directly to /proc for information.
    Lars T Hansen committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    9982f7b View commit details
    Browse the repository at this point in the history

  3. For #53: Propagate errors from the command module, and implement some 

    skeleton logging.

The current error propagation leaks the error code from the command
module up through the layers, even though the "get information" layer
need not run any subcommands.  This can be fixed later if we start
going directly to /proc for information.
    Lars T Hansen committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    4659272 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'propagate_subprocess_error' of https://github.com/lars-… 

    …t-hansen/sonar into propagate_subprocess_error
    Lars T Hansen committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    429beb1 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Better test case

    Lars T Hansen committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    692a86b View commit details
    Browse the repository at this point in the history

  2. Logging stub prints to stderr

    Lars T Hansen committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    f233eee View commit details
    Browse the repository at this point in the history

  3. Reformat

    Lars T Hansen committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    738965e View commit details
    Browse the repository at this point in the history