Fix "Unknown named parameter" PHP 8 error #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi ! Thank you for your contribution, we would like to ask for more details regarding to the version of Prestashop and Nosto module which are you using. I suppose you are using Prestashop 8+ with PHP 8+ but it is better that we want to have confirmation from you. |
|
I have verified both in PHP 7 and 8, it can be merged after all checks above passed |
PHP 8 has named arguments, using the "formatted" argument name in `newInstanceArgs` method seems to trigger "Unknown named parameter error".
phonglynosto
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHP 8 has named arguments, using the "formatted" argument name in
newInstanceArgsmethod seems to trigger "Unknown named parameter error".