Simplify useRenderCampaigns #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timowestnosto
commented
Jul 22, 2024
| @@ -38,7 +36,8 @@ export default function NostoOrder(props: { | |||
| .load() | |||
| renderCampaigns(data, api) | |||
| }, | |||
| [recommendationComponent, pageTypeUpdated] | |||
| [order], | |||
There was a problem hiding this comment.
order was missing
timowestnosto
commented
Jul 22, 2024
| renderCampaigns(data: unknown, api: NostoClient): void | ||
| pageTypeUpdated: boolean | ||
| } | ||
| pageType: string |
There was a problem hiding this comment.
not anymore used
timowestnosto
commented
Jul 22, 2024
| recommendationComponent?: React.ReactElement<{ | ||
| nostoRecommendation: Recommendation | ||
| }> | ||
| useRenderCampaigns(type: string): { |
There was a problem hiding this comment.
moved to standalone hook that uses context internally
timowestnosto
force-pushed
the
use-render-campaigns
branch
from
ca470a9 to
fcbbc48
Compare
timowestnosto
force-pushed
the
use-render-campaigns
branch
from
1d5f133 to
35c0872
Compare
TomJas-nosto
approved these changes
Jul 22, 2024
manikandan-ravikumar
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts useRenderCampaigns out of the main context and reduces the rerun conditions for the Session API side effects