Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: component filter added #176

Merged
merged 25 commits into from
Jan 26, 2024
Merged

feat: component filter added #176

merged 25 commits into from
Jan 26, 2024

Conversation

keeama13
Copy link
Contributor

@keeama13 keeama13 commented Jan 2, 2024 •
edited

TODO:

  • Make sure table has filter component (before filtering)
  • Automatically sent filter values to create form
  • Add LayoutHidden to siteboss layout
  • Add breadcrumbs to filtered table page
  • Maintain filter after saving edit
  • add order to new component
  • Move the custom save out of TableService into the filtercomponent

Base automatically changed from develop to main January 11, 2024 15:14
64knl and others added 9 commits January 11, 2024 16:24
@64knl
fix: only add column when it doesn't exist (#167)
fb8a2cf 
* fix: only add column when it doesn't exist

* style: formatting
@keeama13 @64knl
feat: export cms (#169)
ab66a88 
* feat: import export

* feat: use file instead of database

* feat: move import/export to model

* fix: export from tableitem

* feat: move export to Trait

* style: formatting

* style: formatting

* fix: never use file as source of truth

* style: formatting

* chore: cleanup

* fix: use export to file

* feat: comment things that no longer work

* feat: add  meta data

* feat: list filenames

* feat: cleaner export

* feat: remove UI for import/export

* style: formatting

* feat: add import command

* feat: import from files

* feat: remove import UI

* feat: prevent editing tables with changes on disk

* feat: do not use id's in export for tables

* feat: optionally export ids

* feat: import ids when available

---------

Co-authored-by: Rene <rene@64k.nl>
@keeama13 @64knl
feat: component filter added
f1fd071
@keeama13 @64knl
feat: added filterparams
09f4c64
@keeama13 @64knl
feat: only query if filter exists
6b9d06b
@keeama13 @64knl
feat: WIP
53626d1
@64knl
feat: typed editor classes
859ddc3
@keeama13 @64knl
feat: editor changes
b5076bb
@keeama13 @64knl
feat: removed code
83d2f19
@keeama13 keeama13 changed the base branch from main to develop January 25, 2024 15:05
@keeama13 keeama13 marked this pull request as ready for review January 25, 2024 15:13
64knl
64knl reviewed Jan 25, 2024
View reviewed changes
src/Models/Editor/AbstractEditor.php Outdated

}

public function getBreadCrumbs(bool $edit = false): LayoutBreadCrumb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove parameter

64knl
64knl reviewed Jan 25, 2024
View reviewed changes
src/Services/Assets/Components/ComponentFilter.php Outdated
return;
}

//TODO get data from somewhere else
Copy link
Member

@64knl 64knl Jan 25, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement TODO

@64knl 64knl merged commit 405b0d9 into develop Jan 26, 2024
4 of 5 checks passed
@64knl 64knl deleted the feat/component-filter branch January 26, 2024 13:34
64knl added a commit that referenced this pull request Jan 26, 2024
@64knl @keeama13
feat: component filter added (#176) (#188)
9c69fab 
* fix: only add column when it doesn't exist (#167)

* fix: only add column when it doesn't exist

* style: formatting

* feat: export cms (#169)

* feat: import export

* feat: use file instead of database

* feat: move import/export to model

* fix: export from tableitem

* feat: move export to Trait

* style: formatting

* style: formatting

* fix: never use file as source of truth

* style: formatting

* chore: cleanup

* fix: use export to file

* feat: comment things that no longer work

* feat: add  meta data

* feat: list filenames

* feat: cleaner export

* feat: remove UI for import/export

* style: formatting

* feat: add import command

* feat: import from files

* feat: remove import UI

* feat: prevent editing tables with changes on disk

* feat: do not use id's in export for tables

* feat: optionally export ids

* feat: import ids when available

---------



* feat: component filter added

* feat: added filterparams

* feat: only query if filter exists

* feat: WIP

* feat: typed editor classes

* feat: editor changes

* feat: removed code

* feat: removed request from editor and overview

* feat: added TODO

* chore: update dependency

* feat: migration for model column in cms_table

* fix: retain model on import export cms_table

* feat: moved code to component

* feat: added guards

* style: formatting

* feat: parameters now in tableservice

* feat: removed parameter

* feat: removed request() from editor

* fix: return empty array if key not exists

* style: formatting

* style: formatting

---------

Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
64knl added a commit that referenced this pull request Jan 31, 2024
@64knl @keeama13
Version 0.15.1 (#190)
166ae92 
* feat: component filter added (#176)

* fix: only add column when it doesn't exist (#167)

* fix: only add column when it doesn't exist

* style: formatting

* feat: export cms (#169)

* feat: import export

* feat: use file instead of database

* feat: move import/export to model

* fix: export from tableitem

* feat: move export to Trait

* style: formatting

* style: formatting

* fix: never use file as source of truth

* style: formatting

* chore: cleanup

* fix: use export to file

* feat: comment things that no longer work

* feat: add  meta data

* feat: list filenames

* feat: cleaner export

* feat: remove UI for import/export

* style: formatting

* feat: add import command

* feat: import from files

* feat: remove import UI

* feat: prevent editing tables with changes on disk

* feat: do not use id's in export for tables

* feat: optionally export ids

* feat: import ids when available

---------

Co-authored-by: Rene <rene@64k.nl>

* feat: component filter added

* feat: added filterparams

* feat: only query if filter exists

* feat: WIP

* feat: typed editor classes

* feat: editor changes

* feat: removed code

* feat: removed request from editor and overview

* feat: added TODO

* chore: update dependency

* feat: migration for model column in cms_table

* fix: retain model on import export cms_table

* feat: moved code to component

* feat: added guards

* style: formatting

* feat: parameters now in tableservice

* feat: removed parameter

* feat: removed request() from editor

* fix: return empty array if key not exists

* style: formatting

* style: formatting

---------

Co-authored-by: René <rene@64k.nl>

* fix: exceptions handling (#189)

* fix: exception handling

* style: formatting

* fix: return type

* feat: date helper (#191)

---------

Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
64knl added a commit that referenced this pull request Feb 1, 2024
@64knl @keeama13
feat: Version 0.15.2 (#192)
ab6225b 
* feat: component filter added (#176)

* fix: only add column when it doesn't exist (#167)

* fix: only add column when it doesn't exist

* style: formatting

* feat: export cms (#169)

* feat: import export

* feat: use file instead of database

* feat: move import/export to model

* fix: export from tableitem

* feat: move export to Trait

* style: formatting

* style: formatting

* fix: never use file as source of truth

* style: formatting

* chore: cleanup

* fix: use export to file

* feat: comment things that no longer work

* feat: add  meta data

* feat: list filenames

* feat: cleaner export

* feat: remove UI for import/export

* style: formatting

* feat: add import command

* feat: import from files

* feat: remove import UI

* feat: prevent editing tables with changes on disk

* feat: do not use id's in export for tables

* feat: optionally export ids

* feat: import ids when available

---------

Co-authored-by: Rene <rene@64k.nl>

* feat: component filter added

* feat: added filterparams

* feat: only query if filter exists

* feat: WIP

* feat: typed editor classes

* feat: editor changes

* feat: removed code

* feat: removed request from editor and overview

* feat: added TODO

* chore: update dependency

* feat: migration for model column in cms_table

* fix: retain model on import export cms_table

* feat: moved code to component

* feat: added guards

* style: formatting

* feat: parameters now in tableservice

* feat: removed parameter

* feat: removed request() from editor

* fix: return empty array if key not exists

* style: formatting

* style: formatting

---------

Co-authored-by: René <rene@64k.nl>

* fix: exceptions handling (#189)

* fix: exception handling

* style: formatting

* fix: return type

* feat: date helper (#191)

* feat: moved layoutbar to editor (#193)

* feat: moved layoutbar to editor

* style: formatting

* chore: remove unused methods

---------

Co-authored-by: Rene <rene@64k.nl>

---------

Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
64knl added a commit that referenced this pull request Feb 1, 2024
@64knl @keeama13
fix: cms editor import (#194)
1248eae 
* feat: component filter added (#176)

* fix: only add column when it doesn't exist (#167)

* fix: only add column when it doesn't exist

* style: formatting

* feat: export cms (#169)

* feat: import export

* feat: use file instead of database

* feat: move import/export to model

* fix: export from tableitem

* feat: move export to Trait

* style: formatting

* style: formatting

* fix: never use file as source of truth

* style: formatting

* chore: cleanup

* fix: use export to file

* feat: comment things that no longer work

* feat: add  meta data

* feat: list filenames

* feat: cleaner export

* feat: remove UI for import/export

* style: formatting

* feat: add import command

* feat: import from files

* feat: remove import UI

* feat: prevent editing tables with changes on disk

* feat: do not use id's in export for tables

* feat: optionally export ids

* feat: import ids when available

---------

Co-authored-by: Rene <rene@64k.nl>

* feat: component filter added

* feat: added filterparams

* feat: only query if filter exists

* feat: WIP

* feat: typed editor classes

* feat: editor changes

* feat: removed code

* feat: removed request from editor and overview

* feat: added TODO

* chore: update dependency

* feat: migration for model column in cms_table

* fix: retain model on import export cms_table

* feat: moved code to component

* feat: added guards

* style: formatting

* feat: parameters now in tableservice

* feat: removed parameter

* feat: removed request() from editor

* fix: return empty array if key not exists

* style: formatting

* style: formatting

---------

Co-authored-by: René <rene@64k.nl>

* fix: exceptions handling (#189)

* fix: exception handling

* style: formatting

* fix: return type

* feat: date helper (#191)

* feat: moved layoutbar to editor (#193)

* feat: moved layoutbar to editor

* style: formatting

* chore: remove unused methods

---------

Co-authored-by: Rene <rene@64k.nl>

* fix: do not crash when model is not set

---------

Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
64knl added a commit that referenced this pull request Feb 2, 2024
@64knl @keeama13
feat: Version 0.17.0 (#195)
6cc299e 
* feat: component filter added (#176)

* fix: only add column when it doesn't exist (#167)

* fix: only add column when it doesn't exist

* style: formatting

* feat: export cms (#169)

* feat: import export

* feat: use file instead of database

* feat: move import/export to model

* fix: export from tableitem

* feat: move export to Trait

* style: formatting

* style: formatting

* fix: never use file as source of truth

* style: formatting

* chore: cleanup

* fix: use export to file

* feat: comment things that no longer work

* feat: add  meta data

* feat: list filenames

* feat: cleaner export

* feat: remove UI for import/export

* style: formatting

* feat: add import command

* feat: import from files

* feat: remove import UI

* feat: prevent editing tables with changes on disk

* feat: do not use id's in export for tables

* feat: optionally export ids

* feat: import ids when available

---------

Co-authored-by: Rene <rene@64k.nl>

* feat: component filter added

* feat: added filterparams

* feat: only query if filter exists

* feat: WIP

* feat: typed editor classes

* feat: editor changes

* feat: removed code

* feat: removed request from editor and overview

* feat: added TODO

* chore: update dependency

* feat: migration for model column in cms_table

* fix: retain model on import export cms_table

* feat: moved code to component

* feat: added guards

* style: formatting

* feat: parameters now in tableservice

* feat: removed parameter

* feat: removed request() from editor

* fix: return empty array if key not exists

* style: formatting

* style: formatting

---------

Co-authored-by: René <rene@64k.nl>

* fix: exceptions handling (#189)

* fix: exception handling

* style: formatting

* fix: return type

* feat: date helper (#191)

* feat: moved layoutbar to editor (#193)

* feat: moved layoutbar to editor

* style: formatting

* chore: remove unused methods

---------

Co-authored-by: Rene <rene@64k.nl>

* feat: CMS editor import/export (#197)

* feat: move to service

* style: formatting

* feat: template import

* fix: edit tables

* feat: moved bar items to editor (#196)

* feat: moved bar items to editor

* feat: abstract class

* style: formatting

* feat: updated default editor

---------

Co-authored-by: Rene <rene@64k.nl>

---------

Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
64knl added a commit that referenced this pull request Feb 8, 2024
@64knl @keeama13
feat: Version 0.17.1 (#202)
6164568 
* feat: component filter added (#176)

* fix: only add column when it doesn't exist (#167)

* fix: only add column when it doesn't exist

* style: formatting

* feat: export cms (#169)

* feat: import export

* feat: use file instead of database

* feat: move import/export to model

* fix: export from tableitem

* feat: move export to Trait

* style: formatting

* style: formatting

* fix: never use file as source of truth

* style: formatting

* chore: cleanup

* fix: use export to file

* feat: comment things that no longer work

* feat: add  meta data

* feat: list filenames

* feat: cleaner export

* feat: remove UI for import/export

* style: formatting

* feat: add import command

* feat: import from files

* feat: remove import UI

* feat: prevent editing tables with changes on disk

* feat: do not use id's in export for tables

* feat: optionally export ids

* feat: import ids when available

---------

Co-authored-by: Rene <rene@64k.nl>

* feat: component filter added

* feat: added filterparams

* feat: only query if filter exists

* feat: WIP

* feat: typed editor classes

* feat: editor changes

* feat: removed code

* feat: removed request from editor and overview

* feat: added TODO

* chore: update dependency

* feat: migration for model column in cms_table

* fix: retain model on import export cms_table

* feat: moved code to component

* feat: added guards

* style: formatting

* feat: parameters now in tableservice

* feat: removed parameter

* feat: removed request() from editor

* fix: return empty array if key not exists

* style: formatting

* style: formatting

---------

Co-authored-by: René <rene@64k.nl>

* fix: exceptions handling (#189)

* fix: exception handling

* style: formatting

* fix: return type

* feat: date helper (#191)

* feat: moved layoutbar to editor (#193)

* feat: moved layoutbar to editor

* style: formatting

* chore: remove unused methods

---------

Co-authored-by: Rene <rene@64k.nl>

* feat: CMS editor import/export (#197)

* feat: move to service

* style: formatting

* feat: template import

* fix: edit tables

* feat: moved bar items to editor (#196)

* feat: moved bar items to editor

* feat: abstract class

* style: formatting

* feat: updated default editor

---------

Co-authored-by: Rene <rene@64k.nl>

* fix: editing template items throws error (#201)

* fix: editing template items throws error

* style: formatting

* fix: insights requirements fail

---------

Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
64knl added a commit that referenced this pull request Feb 25, 2024
@64knl @keeama13 @thessakockelkorn
feat: Version 0.18.0 (#204)
7876b47 
* feat: component filter added (#176)

* fix: only add column when it doesn't exist (#167)

* fix: only add column when it doesn't exist

* style: formatting

* feat: export cms (#169)

* feat: import export

* feat: use file instead of database

* feat: move import/export to model

* fix: export from tableitem

* feat: move export to Trait

* style: formatting

* style: formatting

* fix: never use file as source of truth

* style: formatting

* chore: cleanup

* fix: use export to file

* feat: comment things that no longer work

* feat: add  meta data

* feat: list filenames

* feat: cleaner export

* feat: remove UI for import/export

* style: formatting

* feat: add import command

* feat: import from files

* feat: remove import UI

* feat: prevent editing tables with changes on disk

* feat: do not use id's in export for tables

* feat: optionally export ids

* feat: import ids when available

---------

Co-authored-by: Rene <rene@64k.nl>

* feat: component filter added

* feat: added filterparams

* feat: only query if filter exists

* feat: WIP

* feat: typed editor classes

* feat: editor changes

* feat: removed code

* feat: removed request from editor and overview

* feat: added TODO

* chore: update dependency

* feat: migration for model column in cms_table

* fix: retain model on import export cms_table

* feat: moved code to component

* feat: added guards

* style: formatting

* feat: parameters now in tableservice

* feat: removed parameter

* feat: removed request() from editor

* fix: return empty array if key not exists

* style: formatting

* style: formatting

---------

Co-authored-by: René <rene@64k.nl>

* fix: exceptions handling (#189)

* fix: exception handling

* style: formatting

* fix: return type

* feat: date helper (#191)

* feat: moved layoutbar to editor (#193)

* feat: moved layoutbar to editor

* style: formatting

* chore: remove unused methods

---------

Co-authored-by: Rene <rene@64k.nl>

* feat: CMS editor import/export (#197)

* feat: move to service

* style: formatting

* feat: template import

* fix: edit tables

* feat: moved bar items to editor (#196)

* feat: moved bar items to editor

* feat: abstract class

* style: formatting

* feat: updated default editor

---------

Co-authored-by: Rene <rene@64k.nl>

* fix: editing template items throws error (#201)

* fix: editing template items throws error

* style: formatting

* fix: insights requirements fail

* feat: block account route (#103)

* feat: block account route

* feat: messages

* fix: add nullable (#163)

* feat: set null for searchitem (#166)

* fix: fallback to null for SearchItem

* style: formatting

* fix: only add column when it doesn't exist (#167)

* fix: only add column when it doesn't exist

* style: formatting

* feat: dd removed

* feat: add admin e-mail to config

* feat: publish css file

* feat: update block template

* feat: templates

* fix: english language

* feat: template for succes

* style: formatting

---------

Co-authored-by: René <rene@64k.nl>

* feat: add casts to Template model

* feat: catch errors (#199)

* feat: catch errors

* style: formatting

* feat: multiple sites in solr core (#206)

* feat: option to index more than one site in single solr core

* style:formatting

* style: formatting

* style: formatting

---------

Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl>

* feat: add controller column to cms_template (#207)

Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl>

* fix: better cut off (#209)

Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl>

* fix: template import / export (#213)

* feat: add pager to abstract class for bottom bar (#208)

---------

Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
Co-authored-by: thessakockelkorn <70509512+thessakockelkorn@users.noreply.github.com>
Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64knl 64knl 64knl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keeama13 @64knl