fix: exceptions handling #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thessakockelkorn
suggested changes
Jan 30, 2024
64knl
added a commit
that referenced
this pull request
Jan 31, 2024
* feat: component filter added (#176) * fix: only add column when it doesn't exist (#167) * fix: only add column when it doesn't exist * style: formatting * feat: export cms (#169) * feat: import export * feat: use file instead of database * feat: move import/export to model * fix: export from tableitem * feat: move export to Trait * style: formatting * style: formatting * fix: never use file as source of truth * style: formatting * chore: cleanup * fix: use export to file * feat: comment things that no longer work * feat: add meta data * feat: list filenames * feat: cleaner export * feat: remove UI for import/export * style: formatting * feat: add import command * feat: import from files * feat: remove import UI * feat: prevent editing tables with changes on disk * feat: do not use id's in export for tables * feat: optionally export ids * feat: import ids when available --------- Co-authored-by: Rene <rene@64k.nl> * feat: component filter added * feat: added filterparams * feat: only query if filter exists * feat: WIP * feat: typed editor classes * feat: editor changes * feat: removed code * feat: removed request from editor and overview * feat: added TODO * chore: update dependency * feat: migration for model column in cms_table * fix: retain model on import export cms_table * feat: moved code to component * feat: added guards * style: formatting * feat: parameters now in tableservice * feat: removed parameter * feat: removed request() from editor * fix: return empty array if key not exists * style: formatting * style: formatting --------- Co-authored-by: René <rene@64k.nl> * fix: exceptions handling (#189) * fix: exception handling * style: formatting * fix: return type * feat: date helper (#191) --------- Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
64knl
added a commit
that referenced
this pull request
Feb 1, 2024
* feat: component filter added (#176) * fix: only add column when it doesn't exist (#167) * fix: only add column when it doesn't exist * style: formatting * feat: export cms (#169) * feat: import export * feat: use file instead of database * feat: move import/export to model * fix: export from tableitem * feat: move export to Trait * style: formatting * style: formatting * fix: never use file as source of truth * style: formatting * chore: cleanup * fix: use export to file * feat: comment things that no longer work * feat: add meta data * feat: list filenames * feat: cleaner export * feat: remove UI for import/export * style: formatting * feat: add import command * feat: import from files * feat: remove import UI * feat: prevent editing tables with changes on disk * feat: do not use id's in export for tables * feat: optionally export ids * feat: import ids when available --------- Co-authored-by: Rene <rene@64k.nl> * feat: component filter added * feat: added filterparams * feat: only query if filter exists * feat: WIP * feat: typed editor classes * feat: editor changes * feat: removed code * feat: removed request from editor and overview * feat: added TODO * chore: update dependency * feat: migration for model column in cms_table * fix: retain model on import export cms_table * feat: moved code to component * feat: added guards * style: formatting * feat: parameters now in tableservice * feat: removed parameter * feat: removed request() from editor * fix: return empty array if key not exists * style: formatting * style: formatting --------- Co-authored-by: René <rene@64k.nl> * fix: exceptions handling (#189) * fix: exception handling * style: formatting * fix: return type * feat: date helper (#191) * feat: moved layoutbar to editor (#193) * feat: moved layoutbar to editor * style: formatting * chore: remove unused methods --------- Co-authored-by: Rene <rene@64k.nl> --------- Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
64knl
added a commit
that referenced
this pull request
Feb 1, 2024
* feat: component filter added (#176) * fix: only add column when it doesn't exist (#167) * fix: only add column when it doesn't exist * style: formatting * feat: export cms (#169) * feat: import export * feat: use file instead of database * feat: move import/export to model * fix: export from tableitem * feat: move export to Trait * style: formatting * style: formatting * fix: never use file as source of truth * style: formatting * chore: cleanup * fix: use export to file * feat: comment things that no longer work * feat: add meta data * feat: list filenames * feat: cleaner export * feat: remove UI for import/export * style: formatting * feat: add import command * feat: import from files * feat: remove import UI * feat: prevent editing tables with changes on disk * feat: do not use id's in export for tables * feat: optionally export ids * feat: import ids when available --------- Co-authored-by: Rene <rene@64k.nl> * feat: component filter added * feat: added filterparams * feat: only query if filter exists * feat: WIP * feat: typed editor classes * feat: editor changes * feat: removed code * feat: removed request from editor and overview * feat: added TODO * chore: update dependency * feat: migration for model column in cms_table * fix: retain model on import export cms_table * feat: moved code to component * feat: added guards * style: formatting * feat: parameters now in tableservice * feat: removed parameter * feat: removed request() from editor * fix: return empty array if key not exists * style: formatting * style: formatting --------- Co-authored-by: René <rene@64k.nl> * fix: exceptions handling (#189) * fix: exception handling * style: formatting * fix: return type * feat: date helper (#191) * feat: moved layoutbar to editor (#193) * feat: moved layoutbar to editor * style: formatting * chore: remove unused methods --------- Co-authored-by: Rene <rene@64k.nl> * fix: do not crash when model is not set --------- Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
64knl
added a commit
that referenced
this pull request
Feb 2, 2024
* feat: component filter added (#176) * fix: only add column when it doesn't exist (#167) * fix: only add column when it doesn't exist * style: formatting * feat: export cms (#169) * feat: import export * feat: use file instead of database * feat: move import/export to model * fix: export from tableitem * feat: move export to Trait * style: formatting * style: formatting * fix: never use file as source of truth * style: formatting * chore: cleanup * fix: use export to file * feat: comment things that no longer work * feat: add meta data * feat: list filenames * feat: cleaner export * feat: remove UI for import/export * style: formatting * feat: add import command * feat: import from files * feat: remove import UI * feat: prevent editing tables with changes on disk * feat: do not use id's in export for tables * feat: optionally export ids * feat: import ids when available --------- Co-authored-by: Rene <rene@64k.nl> * feat: component filter added * feat: added filterparams * feat: only query if filter exists * feat: WIP * feat: typed editor classes * feat: editor changes * feat: removed code * feat: removed request from editor and overview * feat: added TODO * chore: update dependency * feat: migration for model column in cms_table * fix: retain model on import export cms_table * feat: moved code to component * feat: added guards * style: formatting * feat: parameters now in tableservice * feat: removed parameter * feat: removed request() from editor * fix: return empty array if key not exists * style: formatting * style: formatting --------- Co-authored-by: René <rene@64k.nl> * fix: exceptions handling (#189) * fix: exception handling * style: formatting * fix: return type * feat: date helper (#191) * feat: moved layoutbar to editor (#193) * feat: moved layoutbar to editor * style: formatting * chore: remove unused methods --------- Co-authored-by: Rene <rene@64k.nl> * feat: CMS editor import/export (#197) * feat: move to service * style: formatting * feat: template import * fix: edit tables * feat: moved bar items to editor (#196) * feat: moved bar items to editor * feat: abstract class * style: formatting * feat: updated default editor --------- Co-authored-by: Rene <rene@64k.nl> --------- Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
64knl
added a commit
that referenced
this pull request
Feb 8, 2024
* feat: component filter added (#176) * fix: only add column when it doesn't exist (#167) * fix: only add column when it doesn't exist * style: formatting * feat: export cms (#169) * feat: import export * feat: use file instead of database * feat: move import/export to model * fix: export from tableitem * feat: move export to Trait * style: formatting * style: formatting * fix: never use file as source of truth * style: formatting * chore: cleanup * fix: use export to file * feat: comment things that no longer work * feat: add meta data * feat: list filenames * feat: cleaner export * feat: remove UI for import/export * style: formatting * feat: add import command * feat: import from files * feat: remove import UI * feat: prevent editing tables with changes on disk * feat: do not use id's in export for tables * feat: optionally export ids * feat: import ids when available --------- Co-authored-by: Rene <rene@64k.nl> * feat: component filter added * feat: added filterparams * feat: only query if filter exists * feat: WIP * feat: typed editor classes * feat: editor changes * feat: removed code * feat: removed request from editor and overview * feat: added TODO * chore: update dependency * feat: migration for model column in cms_table * fix: retain model on import export cms_table * feat: moved code to component * feat: added guards * style: formatting * feat: parameters now in tableservice * feat: removed parameter * feat: removed request() from editor * fix: return empty array if key not exists * style: formatting * style: formatting --------- Co-authored-by: René <rene@64k.nl> * fix: exceptions handling (#189) * fix: exception handling * style: formatting * fix: return type * feat: date helper (#191) * feat: moved layoutbar to editor (#193) * feat: moved layoutbar to editor * style: formatting * chore: remove unused methods --------- Co-authored-by: Rene <rene@64k.nl> * feat: CMS editor import/export (#197) * feat: move to service * style: formatting * feat: template import * fix: edit tables * feat: moved bar items to editor (#196) * feat: moved bar items to editor * feat: abstract class * style: formatting * feat: updated default editor --------- Co-authored-by: Rene <rene@64k.nl> * fix: editing template items throws error (#201) * fix: editing template items throws error * style: formatting * fix: insights requirements fail --------- Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com>
64knl
added a commit
that referenced
this pull request
Feb 25, 2024
* feat: component filter added (#176) * fix: only add column when it doesn't exist (#167) * fix: only add column when it doesn't exist * style: formatting * feat: export cms (#169) * feat: import export * feat: use file instead of database * feat: move import/export to model * fix: export from tableitem * feat: move export to Trait * style: formatting * style: formatting * fix: never use file as source of truth * style: formatting * chore: cleanup * fix: use export to file * feat: comment things that no longer work * feat: add meta data * feat: list filenames * feat: cleaner export * feat: remove UI for import/export * style: formatting * feat: add import command * feat: import from files * feat: remove import UI * feat: prevent editing tables with changes on disk * feat: do not use id's in export for tables * feat: optionally export ids * feat: import ids when available --------- Co-authored-by: Rene <rene@64k.nl> * feat: component filter added * feat: added filterparams * feat: only query if filter exists * feat: WIP * feat: typed editor classes * feat: editor changes * feat: removed code * feat: removed request from editor and overview * feat: added TODO * chore: update dependency * feat: migration for model column in cms_table * fix: retain model on import export cms_table * feat: moved code to component * feat: added guards * style: formatting * feat: parameters now in tableservice * feat: removed parameter * feat: removed request() from editor * fix: return empty array if key not exists * style: formatting * style: formatting --------- Co-authored-by: René <rene@64k.nl> * fix: exceptions handling (#189) * fix: exception handling * style: formatting * fix: return type * feat: date helper (#191) * feat: moved layoutbar to editor (#193) * feat: moved layoutbar to editor * style: formatting * chore: remove unused methods --------- Co-authored-by: Rene <rene@64k.nl> * feat: CMS editor import/export (#197) * feat: move to service * style: formatting * feat: template import * fix: edit tables * feat: moved bar items to editor (#196) * feat: moved bar items to editor * feat: abstract class * style: formatting * feat: updated default editor --------- Co-authored-by: Rene <rene@64k.nl> * fix: editing template items throws error (#201) * fix: editing template items throws error * style: formatting * fix: insights requirements fail * feat: block account route (#103) * feat: block account route * feat: messages * fix: add nullable (#163) * feat: set null for searchitem (#166) * fix: fallback to null for SearchItem * style: formatting * fix: only add column when it doesn't exist (#167) * fix: only add column when it doesn't exist * style: formatting * feat: dd removed * feat: add admin e-mail to config * feat: publish css file * feat: update block template * feat: templates * fix: english language * feat: template for succes * style: formatting --------- Co-authored-by: René <rene@64k.nl> * feat: add casts to Template model * feat: catch errors (#199) * feat: catch errors * style: formatting * feat: multiple sites in solr core (#206) * feat: option to index more than one site in single solr core * style:formatting * style: formatting * style: formatting --------- Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl> * feat: add controller column to cms_template (#207) Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl> * fix: better cut off (#209) Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl> * fix: template import / export (#213) * feat: add pager to abstract class for bottom bar (#208) --------- Co-authored-by: Xander Schuurman <44030544+keeama13@users.noreply.github.com> Co-authored-by: thessakockelkorn <70509512+thessakockelkorn@users.noreply.github.com> Co-authored-by: Thessa Kockelkorn <thessa@notfound.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles exceptions better