add basic prometheus metrics with prometheus_flask_exporter #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 62.59% 62.78% +0.18%
==========================================
Files 21 21
Lines 794 798 +4
Branches 113 113
==========================================
+ Hits 497 501 +4
Misses 280 280
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hi @rbelnap ! Thank you for the suggestion. This would be the first "non-functional" dependency added to cellxgene-gateway which gives me some pause. However, it does look really cool, and I don't think there is any competing standard for observability in the python world. Before we go down this path, can you think of a less intrusive way, perhaps that does not involve modifying gateway.py? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a need to monitor the gateway with our existing prometheus infrastructure, this PR just adds generic monitoring for flask, which will work for basic path metrics and up/down monitoring. I plan on adding more useful metrics (cache status and usage, for example) but wanted to gauge interest with a PR early.