Save gene sets without cell annotations #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug whereby new gene_sets csv files created without accompanying cell-level annotations could not be detected by the filecrawler.
|
This looks good to me. I'll need to find time to do some manual testing and cut a release, hopefully will be sometime this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug whereby new gene sets csv files created without accompanying cell-level annotations could not be detected by the filecrawler. Previously, the filecrawler only displayed csv files corresponding to cell-level annotations. This meant that if the user created a new gene set but no cell-level annotations then, whilst the gene-set csv would be saved, they could not be loaded from filecrawler.
Note; this commit also changes the behaviour when checking whether a file is a gene set. It now checks whether the file extension is
self.gene_set_file_suffix(by default,_gene_sets.csv). This means that patterns such asfoo_gene_sets_bar.csvwill no longer count as a gene_sets file. I made this change for convenience here, but obviously please revert if you are worried that it will break things - it just seemed cleaner this way.