Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NQ-2533: Bypass Helper MMCME #25

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

Jonah-Foley
Copy link
Contributor

@Jonah-Foley Jonah-Foley commented Jan 28, 2025

https://nu-quantum.youtrack.cloud/issue/NQ-2533/Bypass-the-helper-MMCME-in-the-Kasli-SoC-WRPC-BSP

In implementing the bypass it was decided that it was worthwhile to break out the xwrc_platform_xilinx.vhd into technology specific files. This PR therefore also introduces an xwrc_platform_kintex7.vhd. This is currently not integrated into xwrc_platform_xilinx.vhd since the same would need to be done for all other technologies before this is feasible, which is an arduous task. The new xwrc_platform_kintex7.vhd is therefore used in xwrc_board_kasli.vhd directly.

@Jonah-Foley Jonah-Foley force-pushed the NQ-2533/bypass-helper-mmcme branch from d46ef1d to 9274ce9 Compare January 28, 2025 14:11
@Jonah-Foley Jonah-Foley force-pushed the NQ-2533/bypass-helper-mmcme branch from 9274ce9 to 7a3c35f Compare January 28, 2025 14:30
@Jonah-Foley Jonah-Foley requested a review from shareefj January 28, 2025 14:34
Copy link
Contributor

@shareefj shareefj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonah-Foley Jonah-Foley merged commit eb42b1a into kasli-soc Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants