Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- adds a workflow to handle stale issues #3437

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

baywet
Copy link
Contributor

@baywet baywet commented Nov 6, 2023

related #3420
TODO:

  • update the delay after which we send a warning to the author
  • update the delay after which we close the issue (after sending the warning)
  • update and/or create the labels
  • update the message to be sent as the reminder
  • decide whether we want the needs author feedback label to be added automatically based on a list of experts.

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@darrelmiller
Copy link
Member

Delay after which we send a warning to the author: 7 days
Delay after which we close the issue (after sending the warning): 28 days
Update and/or create the labels: "Needs author feedback" "No recent activity" "Needs attention"
Message to be sent as the reminder: Add the name of the label. Update the days. Add comment to acknowledge that author can reopen if they want to.
Do we want the needs author feedback label to be added automatically based on a list of experts? Let's not do this for the moment. We will manually add the labels.

@baywet
Copy link
Contributor Author

baywet commented Nov 9, 2023

@darrelmiller @lornajane @webron @MikeRalphson : I updated the delays and the messages. This is ready to merge.
After this gets merged, the labels will need to be created (let me know if you need a script for that), and we'll need to start labeling older issues (again scripting can help with this).

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@earth2marsh
Copy link
Member

Per today's TDC discussion, it's worth having these labels even if we don't have the label names "just right" so far (we can revisit later).

Adding my own thoughts...

  • Needs author feedback works, as it indicates who and what is needed
  • No recent activity seems more like a quality than an actionable label. I think it means that without more community interest, this is likely to be parked or closed? Ideally the name suggests either that this has entered an issues lifecycle category or that an specific action is looming. Some names that come to mind are "stale" (noted on the call has a negative connotation), "Auto-close candidate", or even "Low priority" or "Un-prioritized".
  • Needs attention invites the question of whose attention (not the author, presumably) or what kind of attention is necessary ("triage", "review", for "discussion" etc.).

@earth2marsh earth2marsh merged commit b415dd7 into OAI:main Nov 16, 2023
2 checks passed
@baywet baywet deleted the feature/auto-close-stale-issues branch November 16, 2023 17:33
@baywet
Copy link
Contributor Author

baywet commented Nov 16, 2023

@earth2marsh Thanks for reviewing and merging the workflow

  • No recent activity: is additive to Needs author feedback when it gets added. So hopefully the later still prompts people to do something. Also when No recent activity is added a comment is also added to the issue asking the author to reply or else the issue will be closed.
  • Needs attention: it's deliberate not to use triage because at this point the issue as been triaged and replied to by the team at least once. We could specialize it further to something like Needs reviewers attention if you want to make it clearer.

@earth2marsh
Copy link
Member

So No recent activity then seems like a kind of escalation that requires the author's participation? And is it removed automatically when the author comments? What about Auto-close candidate in that case, as it suggests what will happen in the event the author stays absent?

Needs review or TDC ready or something that indicates better who-must-do-what would help me. :)

One more thought... we have a decent number of labels, so might it help to prefix these workflow labels in order to group them together? Are there good practices we can borrow from other projects here?

@baywet
Copy link
Contributor Author

baywet commented Nov 16, 2023

Yes, no recent activity is an escalation of needs author feedback. I can't remember whether you were on the TDC last week, but you can watch the recording where I walked the audience through the process.

Yes, I'm not dead set on the labels, this is why they can be changed in the workflow simply through changing the environment variables. My only recommendation is not to mix those labels with the triage ones to avoid overcrowding triage.

In terms of good practices, these initial suggestions are borrowed from what we use at Microsoft, and I'm sure they went through thorough political correctness review, as well diversity review (so they are clear to non-native English speakers like me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants