Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.0.4 #4080

Draft
wants to merge 324 commits into
base: main
Choose a base branch
from
Draft

Release v3.0.4 #4080

wants to merge 324 commits into from

Conversation

handrews and others added 30 commits May 22, 2024 09:15
Clarifies that there can be multiple complete OpenAPI documents,
only one of which is an entry OpenAPI document.
Clarify entry/complete document terminology (3.0.4)
Co-authored-by: Mike Kistler <mikekistler@microsoft.com>
Clarify discriminator "*Of" and "mapping" usage (3.0.4)
This acknowledges the ambiguity in the key and value syntax of the
Link Object's `parameter` field, and provides a bit of guidance
on how to implement it.  Sadly it is not possible to fully solve
in a point release.
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
This aligns allowReserved with style by similarly correlating it
with RFC6570 operators.  This will make it easier to write a more
in-depth explanation of the process in an appendix.
This is the one of several appendixes to be added to clarify
the most obscure details of Parameter Object and Encoding Object
serialization.

This clarifies the correspondence between OAS fields and RFC6570
operators, and acknowledges that some field values and combinations
do not have analogues.  It provides further guidance for how to
use RFC6570 implementations to support these configurations.

This includes a SHOULD directive regarding using RFC6570 expansion
with the non-RFC6570 styles, as the use of "explode" and
"allowReserved" does not otherwise make any sense.  It perhaps
could be a MUST.

Examples are included to show both typical usage, and how to
work around the lack of exact RFC6570 equivalences for certain
configurations.
Note that they are resolved in their rendered context.
RFC6570-based serialization will not go beyond what is specified
to unpack arrays and objects.
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
Co-authored-by: Darrel <darrmi@microsoft.com>
* Paramter names don't need to be modeled as template variables.
* Include an example of a parameter name that needs encoding.
* Add more details to the fixed field entries for allowReserved
Guide readers to supplemental documentation, examples, related
specificatioins, and extension registries.  These sites answer
many questions that otherwise get raised as GitHub issues.
* Replace the outdated "model" terminology with "schema"
* Remove the outdated `text/plain` array example, which does not correlate with current OAS requirements
* Rather than replacing the `text/plain` example direclty, enhance the example of serializing `application/json` content in `application/x-www-form-urlencoeded` request bodies.
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
This copies the relevant Parameter Object fields to the Header Object
instead of relying on implicit guidance.  The text for the fields
has been edited to reflect that only headers are being described.

This also include an example of describing a header using the
`content` field, and explaining why it is necessary to do so.
...to placate the PR checks in GitHub.
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
Co-authored-by: Ralf Handl <ralf.handl@sap.com>
@ralfhandl ralfhandl added this to the v3.0.4 milestone Sep 10, 2024
@ralfhandl ralfhandl changed the title Publish v3.0.4 Release v3.0.4 Sep 11, 2024
* Explicitly set `explode: false` in an example as the default
  with `style: form` is `explode: true`; the `explode: true`
  example was also left explicit to reduce confusion.
* Tidy up overly conversational (e.g. "our document") language
  that I'd meant to revisit but forgot about.
* Include the Header Object as one of the places where the
  `style` keyword is used (even if it is the simplest case)
* Minor grammar fix.
* Fix a missing space before an RFC reference.
Style guide conformance.
Also give Appendix C a better name because it is relevant
whether you are using an actual RFC6570 implementation or not.
ralfhandl and others added 2 commits September 12, 2024 16:55
Further guidance on RFC6570 and delimiters
Further clarify link operation ambiguity (3.0.4)
lornajane and others added 4 commits September 12, 2024 17:10
Clarify complete vs self-contained documents
Minor param serialization and wording fixes
The extended example with a multi-document OAD and
a Security Requirement in the referenced document
did to fit well where it was, and there wasn't room in the
Resolving Implicit Connections area.  So this moves
it to an Appendix linked from both locations.
Move complex Sec Req example to appendix F
darrelmiller
darrelmiller previously approved these changes Sep 16, 2024
Copy link
Member

@darrelmiller darrelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite an incredible set of updates. Thank you to all the people that contributed, with a special call out to Henry Andrews who has added so many clarifications to this document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants