Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_payment_order_transfer_journal #1108

Closed
wants to merge 8 commits into from
Closed

[16.0][MIG] account_payment_order_transfer_journal #1108

wants to merge 8 commits into from

Conversation

luc-demeyer
Copy link
Contributor

No description provided.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 29, 2023
@luc-demeyer luc-demeyer force-pushed the 16.0-mig-account_payment_order_transfer_journal branch 2 times, most recently from dec9cf2 to dbfcbbd Compare November 7, 2023 13:15
@luc-demeyer
Copy link
Contributor Author

@pedrobaeza
can you remove the 'stale' from this PR or will it be removed automatically since there is again activity now ?

@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 7, 2023
@pedrobaeza
Copy link
Member

/ocabot migration account_payment_order_transfer_journal

Removed.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 7, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 19, 2023
Open
14 tasks
@luc-demeyer luc-demeyer force-pushed the 16.0-mig-account_payment_order_transfer_journal branch from 68f4fb6 to cf509fe Compare November 7, 2023 19:17
jdidderen-noviat
jdidderen-noviat suggested changes Nov 7, 2023
View reviewed changes
Copy link

@jdidderen-noviat jdidderen-noviat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexis-via
Copy link
Contributor

I support this PR. It's good to have this option in the module account_payment_order.

@luc-demeyer luc-demeyer force-pushed the 16.0-mig-account_payment_order_transfer_journal branch from cf509fe to 4b53d35 Compare December 9, 2023 18:05
@jdidderen-noviat
Copy link

@pedrobaeza @alexis-via @luc-demeyer Is there anything missing to merge this PR and move forward ? I think it would be great to having it merge before reviewing and moving forward with this PR #1174

bosd
bosd approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt dreispt mentioned this pull request Mar 22, 2024
Closed
@dreispt
Copy link
Member

dreispt commented Mar 22, 2024

Superseded by #1243

@dreispt dreispt closed this Mar 22, 2024
@luc-demeyer luc-demeyer mentioned this pull request Apr 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdidderen-noviat jdidderen-noviat jdidderen-noviat approved these changes

@bosd bosd bosd approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@luc-demeyer @pedrobaeza @alexis-via @jdidderen-noviat @OCA-git-bot @dreispt @bosd @adrienpeiffer