Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_payment_order_transfer_journal #1251

Conversation

luc-demeyer
Copy link
Contributor

No description provided.

@luc-demeyer
Copy link
Contributor Author

superceeds #1243 and #1108

The transfer journal functionality has been broken by commit
odoo/odoo@65a1949

This fix adds transfer journal support to this constraint.
@luc-demeyer luc-demeyer force-pushed the 16.0-mig-account_payment_order_transfer_journal branch from 339ab62 to 7c7fbfa Compare April 14, 2024 22:03
@dreispt dreispt closed this Apr 15, 2024
@dreispt dreispt reopened this Apr 15, 2024
@dreispt
Copy link
Member

dreispt commented Apr 15, 2024

Supersedes already reviewed #1108

@dreispt
Copy link
Member

dreispt commented Apr 15, 2024

/ocabot merge mobump

@OCA-git-bot
Copy link
Contributor

Hi @dreispt. Your command failed:

Invalid options for command merge: mobump.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@luc-demeyer
Copy link
Contributor Author

@dreispt
Daniel,

You tried an /ocabot merge nobump (which failed because of a typo).
But this should be /ocabot merge minor (new small feature which requires module upgrade to activate it).
Can you do so ?

Tx,
Luc

@OCA-git-bot
Copy link
Contributor

Sorry @luc-demeyer you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

1 similar comment
@OCA-git-bot
Copy link
Contributor

Sorry @luc-demeyer you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@dreispt
Copy link
Member

dreispt commented Apr 19, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1251-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 19, 2024
Signed-off-by dreispt
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1251-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Member

dreispt commented Apr 19, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1251-by-dreispt-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 522a5e9 into OCA:16.0 Apr 19, 2024
6 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cbe580f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants