[13.0][MIG] privacy #43
Conversation
Renamed module to use the privacy_ convention. Removed report module (to be proposed in own PR). Changed README to the autogenerated new style. Fix website URL rename
Currently translated at 100.0% (36 of 36 strings) Translation: data-protection-12.0/data-protection-12.0-privacy Translate-URL: https://translation.odoo-community.org/projects/data-protection-12-0/data-protection-12-0-privacy/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: data-protection-12.0/data-protection-12.0-privacy Translate-URL: https://translation.odoo-community.org/projects/data-protection-12-0/data-protection-12-0-privacy/
Currently translated at 96.5% (55 of 57 strings) Translation: data-protection-12.0/data-protection-12.0-privacy Translate-URL: https://translation.odoo-community.org/projects/data-protection-12-0/data-protection-12-0-privacy/it/
Currently translated at 100.0% (57 of 57 strings) Translation: data-protection-12.0/data-protection-12.0-privacy Translate-URL: https://translation.odoo-community.org/projects/data-protection-12-0/data-protection-12-0-privacy/it/
Currently translated at 50.9% (29 of 57 strings) Translation: data-protection-12.0/data-protection-12.0-privacy Translate-URL: https://translation.odoo-community.org/projects/data-protection-12-0/data-protection-12-0-privacy/hr/
- think it could be great to add revision activity or action on this model.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: data-protection-12.0/data-protection-12.0-privacy Translate-URL: https://translation.odoo-community.org/projects/data-protection-12-0/data-protection-12-0-privacy/
|
@pedrobaeza @dreispt |
@pedrobaeza ping |
|
Sorry, I don't know enough the module for functional review, but in a first glance, you haven't followed the migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0 that states that you have to do the pre-commit stuff in one first commit. Please change that and I'll do code review later, and my colleague @yajo may review it functionally. |
techultrasolutions
force-pushed
the
13.0-MIG-privacy
branch
from
028b435 to
07e59d1
Compare
@pedrobaeza Above mentioned points are done. |
|
@max3903 Please Review. |
| <record id="base.user_demo" model="res.users"> | ||
| <field name="groups_id" eval="[(4, ref('group_data_protection_user'))]" /> | ||
| </record> | ||
| </data> | ||
| </odoo> |
There was a problem hiding this comment.
No need to add this change, it was like that on purpose.
| @@ -59,4 +57,4 @@ | |||
| groups="group_data_protection_manager" | |||
| sequence="90" | |||
| /> | |||
| </data> | |||
| </odoo> | |||
| @@ -133,4 +132,4 @@ | |||
| id="menu_privacy_activity" | |||
| parent="menu_data_protection_master_data" | |||
| /> | |||
| </data> | |||
| </odoo> | |||
|
This doesn't look good. It's the activities form:
|
| <record id="action_data_protection_config" model="ir.actions.act_window"> | ||
| <field name="name">Data Protection Settings</field> | ||
| <field name="type">ir.actions.act_window</field> | ||
| <field name="res_model">res.config.settings</field> | ||
| <field name="view_mode">form</field> | ||
| <field name="target">inline</field> | ||
| <field name="context">{'module': 'data_protection'}</field> | ||
| </record> |
There was a problem hiding this comment.
This menu item leads to settings, yes, but there are no privacy-related settings. Is that normal? Maybe it's a submodule that needs this hook here? Otherwise it could be removed.
|
I was pushing an alternate PR and accidentally I pushed 16b58ea to the main 13.0 branch 🙈. I was testing odoo-module-migrator and got bit by OCA/odoo-module-migrator#47, which I hope is merged soon. I'm very sorry for that, but it's done already, so I'll close this PR. If there's anything to change, please open a new one. |
Data Privacy and Protection
This application provides data protection and privacy feature,
to comply with regulations such as GDPR.