Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not track remote branch when creating #47

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Do not track remote branch when creating #47

merged 1 commit into from
Dec 15, 2020

Conversation

yajo
Copy link
Member

@yajo yajo commented Dec 15, 2020

Otherwise, doing git push with your 13.0-mig-mymodule branch will push to OCA/13.0 directly!

@Tecnativa TT25940

Do not track remote branch when creating
3f638ff 
Otherwise, doing `git push` with your `13.0-mig-mymodule` branch will push to `OCA/13.0` directly!

@Tecnativa TT25940
@yajo yajo added the bug Something isn't working label Dec 15, 2020
@yajo yajo mentioned this pull request Dec 15, 2020
Closed
@yajo
Copy link
Member Author

yajo commented Dec 15, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch master-ocabot-merge-pr-47-by-Yajo-bump-nobump, awaiting test results.

@yelizariev
Copy link
Member

yelizariev commented Dec 15, 2020 •
edited
Loading

@yajo I wonder, do you plan to use this tool manually or as a part of another project?

@OCA-git-bot OCA-git-bot merged commit c3c7bb2 into OCA:master Dec 15, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c3c7bb2. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the no-track-when-creating-branch branch December 16, 2020 09:26
@yajo
Copy link
Member Author

yajo commented Dec 16, 2020

@yelizariev I have considered the work of migrating modules pointless since long ago, just see odoo/odoo#25371 (comment), OCA/maintainer-tools#334 and OCA/maintainer-tools#381 for example. I consider those ones as lost battles, so I don't care anymore, 🤷🏼‍♂️ but indeed I still think its 90% time loss.

If this tool helps people lose less time, or at least gives me the feeling that mine is not completely lost, it seems good to me. So, ATM I'm just giving it a test flight. No more plans so far.

@yajo yajo mentioned this pull request Jan 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Assignees
No one assigned
Labels
approved bug Something isn't working merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yajo @OCA-git-bot @yelizariev @ivantodorovich @pedrobaeza