13.0 mig hr job category #707
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_job_category Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_job_category/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_job_category Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_job_category/de/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_job_category Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_job_category/pt_BR/
|
|
||
| @api.multi | ||
| def _remove_tags(self, employee_id=None, job_id=None): | ||
| # TODO write tags only once |
There was a problem hiding this comment.
Another way to do this function would be to keep a list of the ids you want to keep and then perform a [(6, 0, [ids])] write.
This way you would only do one write but if don't know if it is more efficient or not. If we want to keep it like this we can remove the TODO
| _logger.debug('Removing employee tags if tag exists on contract ' | ||
| 'job: %s', empl_tags) | ||
| job = self.env["hr.job"].browse(job_id) | ||
| _logger.debug( |
| _logger.debug("Adding employee tag if job tag doesn't " | ||
| "exists: %s", tag.name) | ||
| employee.write({'category_ids': [(4, tag.id)]}) | ||
| _logger.debug( |
| job will be attached to the employee record as well. |
|
This PR has the |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-707-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
@Murtaza-Mithaiwala Hi! Could you pre-commit this module? |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-707-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Has been merged in -> #895 |
|
merged #895 |
No description provided.