[13.0][MIG] hr_job_category #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hr_job_category/models/hr.py
Outdated
|
|
||
| def write(self, vals): | ||
| res = super().write(vals) | ||
| if "job_id" in vals: |
There was a problem hiding this comment.
if the employee was changed you are not removing tags from him
jarroyomorales
force-pushed
the
13.0-mig-hr_job_category
branch
2 times, most recently
from
05b8b66 to
93021fd
Compare
jarroyomorales
force-pushed
the
13.0-mig-hr_job_category
branch
from
93021fd to
339118f
Compare
jarroyomorales
force-pushed
the
13.0-mig-hr_job_category
branch
from
339118f to
a0ff71a
Compare
etobella
approved these changes
Oct 1, 2020
|
This PR has the |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 51fa0af. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of
hr_job_categoryand simplified code.@etobella @Nikul-Chaudhary @i-vyshnevska @alexey-pelykh