[15.0][FIX] mail_tracking: forward ports #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until now, the `sent` event type was never processed, probably because it "made no sense", as an unsent email would never trigger an event. However, it makes sense to process it because you may have a local relay that transmits mails over to the mail provider. In those circumstances, you should have 2 "sent" events (one from the relay and another one from the provider). Also marked some useless parts of code for removal. @Tecnativa TT32365
Refine which mail tracking record is allowed to see. We can rely on the ACLs of the related records so we minimize inconvenient message subject leaks. A regular user can read these mail.tracking.email records: - Those with a linked mail.message that the user can read - Those with a linked mail.mail that the user can read - Those with no message/mail link but a linked partner that the user can read. - Those with no linked records. TT31399
pedrobaeza
approved these changes
Jan 31, 2023
carlosdauden
approved these changes
Feb 1, 2023
|
/ocabot merge major |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
And now only v16 is missing |
|
Congratulations, your PR was merged at 6488ddc. Thanks a lot for contributing to OCA. ❤️ |
SiesslPhillip
pushed a commit
to grueneerde/OCA-social
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/social (17.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward:
cc @Tecnativa
ping @pedrobaeza