[16.0][MIG] mail_tracking: Migration to 16.0 #1091

maq-adhoc · 2023-03-07T14:16:18Z

I restart the mail tracking migration, taking changes from PR #1029 and adding my own changes.
I restarted to be able to do it with the odoo-module-migrate tool and the commits are clean and include PRs #1053 ,#1056 ,#1057.
I also modified the way we inherit MessagingInitializer so that it does not conflict with other modules, e.g. Voip.

* [ADD] mail_tracking addon * Add description icon * Fixes remarked * Fix Travis error * Remarks fixed

…ent events (OCA#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes

* Improve tests * Show trackings even if partner removed * Disable CSRF protection to webhooks controllers

…s and contacts to bounce (OCA#133)

…oved (OCA#132)

As regular users can't access this object.

* [FIX] Only one data-odoo-tracking-email tag in each email * [FIX] Get status even in multicompany instances

On our server, queries based on "mail_tracking_event"."tracking_email_id" improved from 501,924 ms to 1,840 ms queries based on "mail_tracking_email"."mail_message_id" improved from 167,436 ms to 3,223 ms The last ones are run several times when a thread has many messages

Currently translated at 100.0% (82 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/fr/

Closes OCA#303

For giving more priority to other buttons like the invoices one.

Currently translated at 96.3% (79 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/ca/

Or infinite recursions will happen on other `write` overwrites, like the one that happens on `mass_mailing_partner`.

[UPD] Show Failedmsg on Chatbox

nguyenminhchien

lgtm

bhaveshselarka · 2023-08-01T10:43:19Z

#1191

payen000

I tested this functionally and seems to be working as expected.

This will be ready to merge once the unused files are deleted and the commits are sorted out (as there are too many commits right now).

Edit:

My bad, I didn't realize the many commits were the module's commit history.

payen000 · 2023-08-01T18:02:23Z

mail_tracking/static/src/js/models/mailbox.esm.js

+            compute() {
+                switch (this) {
+                    case this.messaging.failedmsg:
+                        return this.env._t("Failedmsg");


Suggested change

return this.env._t("Failedmsg");

return this.env._t("Failed");

To maintain consistency with previous versions, I think this shoud say "Failed" instead.

payen000 · 2023-08-01T18:06:47Z

mail_tracking/static/src/js/failed_message/thread.esm.js

@@ -0,0 +1,58 @@
+/** @odoo-module **/


This file seems to not be needed anymore, so we can delete it

payen000 · 2023-08-01T18:21:07Z

mail_tracking/static/src/js/failed_message/discuss.js

@@ -0,0 +1,411 @@
+/* Copyright 2019 Alexandre Díaz


Is this file in use? If not, I think we should delete it before merging

payen000 · 2023-08-08T18:35:33Z

Hello @maq-adhoc,

I left some comments for you, could you check them please?

I believe the module is working as it should and will be ready to merge once we delete the unused file(s) and switch "Failedmsg" by "Failed", or is there anything else that I'm missing?

cvinh

Hello
Could you please forward port this PR : #941 ?
Thanks

payen000 · 2023-09-05T21:18:56Z

Superseded by #1216

However, I do believe this PR was already working properly, I'm only opening the other PR due to inactivity here, as I need the module working in v16 as soon as possible.

Refactored MessagingInitializer's Init method so that it does not conflict with other modules; see original PR: OCA#1091 Co-authored-by: filoquin <filoquin@gmail.com>

Redo of PRs - OCA#1091 - OCA#1191 Co-authored-by: filoquin <filoquin@gmail.com>

Syncing from upstream OCA/social (12.0)

antespi and others added 30 commits March 2, 2023 09:48

[8.0][ADD] mail_tracking addon (OCA#67)

de61cab

* [ADD] mail_tracking addon * Add description icon * Fixes remarked * Fix Travis error * Remarks fixed

[8.0][IMP][mail_tracking] Speed installation time and discard concurr…

b36c9cb

…ent events (OCA#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes

[FIX] Update email_score when email changes

5d39a54

[MIG] mail_tracking

84310c3

* Improve tests * Show trackings even if partner removed * Disable CSRF protection to webhooks controllers

[FIX] mail_tracking: Typo

309ded3

[MIG] Make modules uninstallable

d8827ea

[MIG] mail_tracking: Migrated to 10.0

1a81043

[IMP] mail_tracking performance and bounce process (OCA#103)

f1dee4b

[IMP] mail_tracking: Allow to define a custom mail_tracking base url

7de177e

Add access to portal/public user to his own email trackings

587f56c

[8.0][FIX][mail_tracking] Use event recipient address to find partner…

67fd2d4

…s and contacts to bounce (OCA#133)

[9.0][FIX][mail_tracking] Control exception when mail_message was rem…

0cc2e97

…oved (OCA#132)

[FIX] Sender label is repeated in search fields

11c7a84

[FIX][9.0] partner buttons view on enterprise

af3d2bd

[FIX] mail_tracking: Obtain outgoing server with sudo

8790fce

As regular users can't access this object.

[IMP] Shut mock exceptions up

6dc1e4b

[9.0][IMP] mail_tracking: Improve view with error details

3343e68

[FIX] mail_tracking: bugfixes (OCA#199)

9b7d55d

* [FIX] Only one data-odoo-tracking-email tag in each email * [FIX] Get status even in multicompany instances

[FIX] mail_tracking js could break other modules using chat_manager

0e2043c

[MIG] mail_tracking: Migration to 11.0

72fedd8

Translated using Weblate (French) [ci skip]

6cc2a6f

Currently translated at 100.0% (82 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/fr/

[IMP] mail_tracking: email score performance (OCA#299)

c6feae0

Fix README.rst images not visible in GitHub and Odoo

eca7d8f

Closes OCA#303

[IMP] mail_tracking: Put button box at the end of the view

5011cd8

For giving more priority to other buttons like the invoices one.

Translated using Weblate (Catalan)

508ef24

Currently translated at 96.3% (79 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/ca/

[MIG] mail_tracking: Migration to 12.0

cdf062e

[FIX] mail_tracking: Don't call write inside other write

3539ecb

Or infinite recursions will happen on other `write` overwrites, like the one that happens on `mass_mailing_partner`.

[IMP] mail_tracking: Cc

c25f100

[MIG] mail_tracking: Adapt Cc to 12.0

e7a0741

Merge pull request #2 from nguyenminhchien/16.0-mig-mail_tracking_1091

4e62047

[UPD] Show Failedmsg on Chatbox

nguyenminhchien approved these changes Jul 14, 2023

View reviewed changes

astirpe mentioned this pull request Aug 1, 2023

[16.0][MIG] mail_tracking: Migration to 16.0 #1191

Closed

payen000 reviewed Aug 1, 2023

View reviewed changes

cvinh suggested changes Aug 11, 2023

View reviewed changes

payen000 mentioned this pull request Sep 5, 2023

[16.0][MIG] mail_tracking: Migration to 16.0 #1216

Merged

pedrobaeza closed this Sep 21, 2023

payen000 added a commit to vauxoo-dev/social that referenced this pull request Sep 21, 2023

[MIG] mail_tracking: migration to 16.0

77df5b8

Redo of PRs - OCA#1091 - OCA#1191 Co-authored-by: filoquin <filoquin@gmail.com>

payen000 added a commit to vauxoo-dev/social that referenced this pull request Sep 21, 2023

[MIG] mail_tracking: migration to 16.0

eae4b50

Redo of PRs - OCA#1091 - OCA#1191 Co-authored-by: filoquin <filoquin@gmail.com>

SiesslPhillip pushed a commit to grueneerde/OCA-social that referenced this pull request Nov 20, 2024

Merge pull request OCA#1091 from OCA/12.0

c0a032e

Syncing from upstream OCA/social (12.0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] mail_tracking: Migration to 16.0 #1091

[16.0][MIG] mail_tracking: Migration to 16.0 #1091

maq-adhoc commented Mar 7, 2023

nguyenminhchien left a comment

bhaveshselarka commented Aug 1, 2023

payen000 left a comment •

edited

Loading

payen000 Aug 1, 2023

payen000 Aug 1, 2023

payen000 Aug 1, 2023

payen000 commented Aug 8, 2023

cvinh left a comment

payen000 commented Sep 5, 2023

	return this.env._t("Failedmsg");
	return this.env._t("Failed");

[16.0][MIG] mail_tracking: Migration to 16.0 #1091

[16.0][MIG] mail_tracking: Migration to 16.0 #1091

Conversation

maq-adhoc commented Mar 7, 2023

nguyenminhchien left a comment

Choose a reason for hiding this comment

bhaveshselarka commented Aug 1, 2023

payen000 left a comment • edited Loading

Choose a reason for hiding this comment

payen000 Aug 1, 2023

Choose a reason for hiding this comment

payen000 Aug 1, 2023

Choose a reason for hiding this comment

payen000 Aug 1, 2023

Choose a reason for hiding this comment

payen000 commented Aug 8, 2023

cvinh left a comment

Choose a reason for hiding this comment

payen000 commented Sep 5, 2023

payen000 left a comment •

edited

Loading