[15.0][MIG] `web_advanced_search`: Migration to 15.0 #2153

ivantodorovich · 2022-02-21T20:45:41Z

Superseeds #2133

and replace company icon [FIX] js syntax [FIX] move our patched equals operator to top of list [ADD] support selecting domains on x2x fields [FIX] eval search view's domain [IMP] UI fixes [IMP] reflect recent additions in README.rst [FIX] typos [ADD] translations [FIX] correct js reference [RFR] rebuild our domains in a different way this solves timing problems

I could not find the project on Transifex...

Change fitro by dominio

- Use the new domain widget. - Use modules system.

* Make it good-looking * Update known issues * Fix templates. * Make other operators work again

[MIG] web_advanced_search_x2x: Migrated to 10.0 FIX review Remarks

* Ensure that domain field can be evaluated before creating x2x field * Fixed navigation error after using x2x advanced search

[FIX] StopPropagation when clicking in domain selector.

* Complete migration to v11 * Refactor to use the new v11 decoupled widgets system * Advanced search is now a high-level feature from the filters menu; it simplifies code a lot, and the UX is even better * Split README system * Add fun to ROADMAP * Addon is renamed to web_advanced_search, since it enhaces the searching experience for all kind of fields now

Currently translated at 100,0% (1 of 1 strings) Translation: web-11.0/web-11.0-web_advanced_search Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_advanced_search/da/

Before this patch, when searching with the "equals to" operator in any x2many field, the searched parameter was always `undefined`. The problem was that the underlying field manager implementation was treating those fields as x2many, while the widget used was the `one2many` one. This patch simply mocks the underlying fake record to make think that any relational field is always a `one2many`. This sets all pieces in place and makes the field manager work as expected, and thus you can search as expected too.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

@http

If we honor the domain value, the user may not be getting all available records when selecting from an x2many dropdown, or even worse, if the domain references another field in the view, the user may be getting an error when opening the field dropdown, like this: Error: NameError: name 'company_id' is not defined http://localhost/web/static/lib/py.js/lib/py.js:370 Rastreo de error: PY_ensurepy@http://localhost/web/static/lib/py.js/lib/py.js:370:19 py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1340:20 py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1397:35 py.evaluate@http://localhost/web/static/lib/py.js/lib/py.js:1409:34 py.eval@http://localhost/web/static/lib/py.js/lib/py.js:1453:16 eval_domains/<@http://localhost/web/static/src/js/core/pyeval.js:886:39 _.forEach@http://localhost/web/static/lib/underscore/underscore.js:145:9 _.mixin/</_.prototype[name]@http://localhost/web/static/lib/underscore/underscore.js:1484:29 eval_domains@http://localhost/web/static/src/js/core/pyeval.js:877:16 pyeval@http://localhost/web/static/src/js/core/pyeval.js:988:16 stringToArray@http://localhost/web/static/src/js/core/domain.js:243:16 _getDomain@http://localhost/web/static/src/js/views/basic/basic_model.js:3004:24 _search@http://localhost/web_m2x_options/static/src/js/form.js:139:26 source@http://localhost/web/static/src/js/fields/relational_fields.js:198:17 _search@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:6823:3 $.widget/</proxiedPrototype[prop]</<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:415:19 search@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:6815:10 $.widget/</proxiedPrototype[prop]</<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:415:19 $.widget.bridge/$.fn[name]/<@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:508:19 each@http://localhost/web/static/lib/jquery/jquery.js:383:49 each@http://localhost/web/static/lib/jquery/jquery.js:136:24 $.widget.bridge/$.fn[name]@http://localhost/web/static/lib/jquery.ui/jquery-ui.js:494:4 _onInputClick@http://localhost/web/static/src/js/fields/relational_fields.js:565:13 proxy/<@http://localhost/web/static/src/js/core/mixins.js:279:20 dispatch@http://localhost/web/static/lib/jquery/jquery.js:4640:50 add/elemData.handle@http://localhost/web/static/lib/jquery/jquery.js:4309:41

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-12.0/web-12.0-web_advanced_search Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_advanced_search/

Currently translated at 100.0% (1 of 1 strings) Translation: web-12.0/web-12.0-web_advanced_search Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_advanced_search/fr/

Currently translated at 100.0% (1 of 1 strings) Translation: web-12.0/web-12.0-web_advanced_search Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_advanced_search/es/

Currently translated at 100.0% (1 of 1 strings) Translation: web-12.0/web-12.0-web_advanced_search Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_advanced_search/pt/

ivantodorovich · 2022-02-22T12:01:41Z

.eslintrc.yml

@@ -4,7 +4,7 @@ env:

 # See https://github.com/OCA/odoo-community.org/issues/37#issuecomment-470686449
 parserOptions:
-  ecmaVersion: 2017
+  ecmaVersion: 2019


[IMP] eslint: bump to escmascript 2019 oca-addons-repo-template#122

onurugur · 2022-02-22T12:35:10Z

@ivantodorovich when pressing the filter

UncaughtPromiseError
Uncaught Promise > Cannot find the definition of component "AdvancedFilterItem"

Error: Cannot find the definition of component "AdvancedFilterItem"
    at QWeb.eval (eval at _compile (http://localhost:9090/web/assets/debug/web.assets_common.js:10280:28), <anonymous>:140:27) (/web/static/lib/owl/owl.js:1795)
    at QWeb.eval (eval at _compile (http://localhost:9090/web/assets/debug/web.assets_common.js:10280:28), <anonymous>:58:21) (/web/static/lib/owl/owl.js:1795)
    at QWeb.render (http://localhost:9090/web/assets/debug/web.assets_common.js:10201:32) (/web/static/lib/owl/owl.js:1716)
    at Dropdown.__render (http://localhost:9090/web/assets/debug/web.assets_common.js:13055:37) (/web/static/lib/owl/owl.js:4570)
    at http://localhost:9090/web/assets/debug/web.assets_common.js:12800:26 (/web/static/lib/owl/owl.js:4315)

also in console

2VM3596:140 Uncaught (in promise) Error: Cannot find the definition of component "AdvancedFilterItem"
    at QWeb.eval (eval at _compile (owl.js:1795:1), <anonymous>:140:27)
    at QWeb.eval (eval at _compile (owl.js:1795:1), <anonymous>:58:21)
    at QWeb.render (owl.js:1716:1)
    at Dropdown.__render (owl.js:4570:1)
    at owl.js:4315:1

Would you check these?

ivantodorovich · 2022-02-22T12:43:40Z

@ivantodorovich when pressing the filter

Would you check these?

Sorry about this. It's fixed now.
I forgot to rename the imports after renaming the files to have pre-commit pass 😅

onurugur · 2022-02-22T12:53:26Z

Thank you. It working. Well done.

celm1990

functional testing OK

Steps to reproduce: 1. Install Sales app 2. Go to Sales > Reporting > Sales 3. Add Custom Filter > Product > Is equal to Without this fix an error is raised: relational.js:39 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'endsWith') at Class.init (relational.js:39:28) --- This is a backport of a refactor made in Migration to 15.0 OCA#2153 The code is a bit simpler an less hacky now, respecting widgets hierarchy and responsibilities.

pedrobaeza · 2022-02-24T20:02:03Z

A missing gap that I have always missed is that on advanced filter, on a many2one, there's no option of searching "is equal to" but the many2one widget. Only to put the exact text or the ID.

ivantodorovich · 2022-02-25T20:20:28Z

A missing gap that I have always missed is that on advanced filter, on a many2one, there's no option of searching "is equal to" but the many2one widget. Only to put the exact text or the ID.

What do you mean? 🤔

pedrobaeza · 2022-02-25T20:25:52Z

I mean to have this:

here:

HaraldPanten · 2022-03-04T14:07:15Z

Hi, any news about this PR?

THX!

OCA-git-bot · 2022-03-05T16:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ghost · 2022-03-07T09:41:05Z

@yajo can you please merge this PR?

yajo · 2022-03-07T13:16:00Z

/ocabot merge nobump

OCA-git-bot · 2022-03-07T13:16:53Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2153-by-Yajo-bump-nobump, awaiting test results.

OCA-git-bot · 2022-03-07T13:21:25Z

Congratulations, your PR was merged at 8d02103. Thanks a lot for contributing to OCA. ❤️

hbrunn and others added 30 commits February 21, 2022 17:40

[I18N] FR translation for web_advanced_search_x2x

6ea0c02

I could not find the project on Transifex...

[IMP] web_advanced_search_x2x spanish translation

a5dbffc

Change fitro by dominio

web_advanced_search_x2x module

e5c142d

Adapt to v9 API.

524264a

- Use the new domain widget. - Use modules system.

inhibit closing the menu when selecting from the dropdown

6b3553b

[FIX] web_advanced_search_x2x: Several things

5bb2ee4

* Make it good-looking * Update known issues * Fix templates. * Make other operators work again

[MIG] web_advanced_search_x2x: Migrated to 10.0

c08bd35

[MIG] web_advanced_search_x2x: Migrated to 10.0 FIX review Remarks

[FIX] Compatibilize web_widget_domain_v11 with web_advanced_search_x2x

ffa10a8

[FIX] web_advanced_search: 2 fixes

e51140f

* Ensure that domain field can be evaluated before creating x2x field * Fixed navigation error after using x2x advanced search

OCA Transbot updated translations from Transifex

1f0c78b

[UPD] Update web_advanced_search_x2x.pot

23bf949

[MIG] web_advanced_search_x2x: Migration to 11.0

b0ffa80

[FIX] StopPropagation when clicking in domain selector.

[UPD] Update web_advanced_search.pot

857beeb

[UPD] README.rst

94c8d9f

Added translation using Weblate (Danish)

54cc2f8

Currently translated at 100,0% (1 of 1 strings) Translation: web-11.0/web-11.0-web_advanced_search Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_advanced_search/da/

[FIX] web_advanced_search: Make linter happy

578d2b3

web_advanced_search: fix 1st domain node load

696f1ca

Update translation files

7231d0f

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[MIG] web_advanced_search: Migrate to v12

cbecd4f

[UPD] Update web_advanced_search.pot

c5aae38

Update translation files

2342784

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-12.0/web-12.0-web_advanced_search Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_advanced_search/

Translated using Weblate (French)

d290870

Currently translated at 100.0% (1 of 1 strings) Translation: web-12.0/web-12.0-web_advanced_search Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_advanced_search/fr/

[UPD] README.rst

6f90bb9

Translated using Weblate (Spanish)

8793d05

Currently translated at 100.0% (1 of 1 strings) Translation: web-12.0/web-12.0-web_advanced_search Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_advanced_search/es/

Added translation using Weblate (Portuguese)

66ab384

Translated using Weblate (Portuguese)

43afbca

Currently translated at 100.0% (1 of 1 strings) Translation: web-12.0/web-12.0-web_advanced_search Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_advanced_search/pt/

This comment was marked as resolved.

Sign in to view

ivantodorovich force-pushed the 15.0-mig-web_advanced_search branch from 257f67e to a03bd34 Compare February 22, 2022 11:53

ivantodorovich commented Feb 22, 2022

View reviewed changes

ivantodorovich force-pushed the 15.0-mig-web_advanced_search branch 2 times, most recently from 6249b8a to f4dd577 Compare February 22, 2022 12:05

ivantodorovich added 2 commits February 22, 2022 09:42

[MIG] web_advanced_search: Migration to 15.0

f3999c2

[UPD] eslint: ecmascript version 2019

59e0361

ivantodorovich force-pushed the 15.0-mig-web_advanced_search branch from f4dd577 to 59e0361 Compare February 22, 2022 12:43

celm1990 approved these changes Feb 22, 2022

View reviewed changes

ivantodorovich mentioned this pull request Feb 24, 2022

[14.0][FIX] web_advanced_search: relational widget on sale.report #2154

Closed

flachica approved these changes Mar 5, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 5, 2022

OCA-git-bot added the bot is merging ⏳ label Mar 7, 2022

OCA-git-bot merged commit 0f8dc0c into OCA:15.0 Mar 7, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] `web_advanced_search`: Migration to 15.0 #2153

[15.0][MIG] `web_advanced_search`: Migration to 15.0 #2153

ivantodorovich commented Feb 21, 2022 •

edited

Loading

This comment was marked as resolved.

ivantodorovich Feb 22, 2022

onurugur commented Feb 22, 2022

ivantodorovich commented Feb 22, 2022

onurugur commented Feb 22, 2022

celm1990 left a comment

pedrobaeza commented Feb 24, 2022

ivantodorovich commented Feb 25, 2022

pedrobaeza commented Feb 25, 2022

HaraldPanten commented Mar 4, 2022

OCA-git-bot commented Mar 5, 2022

ghost commented Mar 7, 2022

yajo commented Mar 7, 2022

OCA-git-bot commented Mar 7, 2022

OCA-git-bot commented Mar 7, 2022

[15.0][MIG] web_advanced_search: Migration to 15.0 #2153

[15.0][MIG] web_advanced_search: Migration to 15.0 #2153

Conversation

ivantodorovich commented Feb 21, 2022 • edited Loading

This comment was marked as resolved.

ivantodorovich Feb 22, 2022

Choose a reason for hiding this comment

onurugur commented Feb 22, 2022

ivantodorovich commented Feb 22, 2022

onurugur commented Feb 22, 2022

celm1990 left a comment

Choose a reason for hiding this comment

pedrobaeza commented Feb 24, 2022

ivantodorovich commented Feb 25, 2022

pedrobaeza commented Feb 25, 2022

HaraldPanten commented Mar 4, 2022

OCA-git-bot commented Mar 5, 2022

ghost commented Mar 7, 2022

yajo commented Mar 7, 2022

OCA-git-bot commented Mar 7, 2022

OCA-git-bot commented Mar 7, 2022

[15.0][MIG] `web_advanced_search`: Migration to 15.0 #2153

[15.0][MIG] `web_advanced_search`: Migration to 15.0 #2153

ivantodorovich commented Feb 21, 2022 •

edited

Loading