[14.0][FIX] web_advanced_search: relational widget on sale.report
#2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce:
1. Install Sales app
2. Go to Sales > Reporting > Sales
3. Add Custom Filter > Product > Is equal to
Without this fix an error is raised:
relational.js:39 Uncaught (in promise)
TypeError: Cannot read properties of undefined (reading 'endsWith')
at Class.init (relational.js:39:28)
---
This is a backport of a refactor made in Migration to 15.0
OCA#2153
The code is a bit simpler an less hacky now, respecting widgets
hierarchy and responsibilities.
yajo
approved these changes
Mar 9, 2022
|
I can't reproduce it neither now.. 😮 |
|
So, do you think this PR is still worth it? |
|
Can't reproduce anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Without this fix an error is raised:
This is a backport of a refactor made in Migration to 15.0
web_advanced_search: Migration to 15.0 #2153The code is a bit simpler an less hacky now, respecting widgets hierarchy and responsibilities.